chrome/test/data/banners/manifest_bad_badge.json - Issue 2791923005: Fails InstallableManager if a selected badge icon cannot be fetched.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/banners/manifest_bad_badge.json

Issue 2791923005: Fails InstallableManager if a selected badge icon cannot be fetched. (Closed)

Patch Set: Addressing comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 {

	2 "name": "Manifest test app",

	3 "icons": [

	4 {

	5 "src": "launcher-icon-1x.png",

	6 "sizes": "48x48",

	7 "type": "image/png"

	8 },

	9 {

	10 "src": "launcher-icon-1-5x.png",

	11 "sizes": "72x72",

	12 "type": "image/png"

	13 },

	14 {

	15 "src": "bad_icon.png",

	16 "sizes": "96x96",

	17 "type": "image/png",

	18 "purpose": "any badge"

	19 },

	20 {

	21 "src": "launcher-icon-3x.png",

	22 "sizes": "144x144",

	23 "type": "image/png"

	24 },

	25 {

	26 "src": "launcher-icon-4x.png",

	27 "sizes": "192x192",

	28 "type": "image/png"

	29 },

	30 {

	31 "src": "image-512px.png",

	32 "sizes": "512x512",

	33 "type": "image/png"

	34 }

	35 ],

	36 "start_url": "manifest_test_page.html",

	37 "display": "standalone",

	38 "orientation": "landscape"

	39 }

OLD	NEW

« no previous file with comments | « chrome/browser/installable/installable_manager_browsertest.cc ('k') | no next file » | no next file with comments »