Pref service: have Mash and Chrome connect to the right pref stores

services/preferences/pref_store_manager_impl.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SERVICES_PREFERENCES_PREF_STORE_MANAGER_IMPL_H_
 #define SERVICES_PREFERENCES_PREF_STORE_MANAGER_IMPL_H_
 
 #include <memory>
 #include <set>
 #include <unordered_map>
@@ skipping 25 matching lines @@
 class PrefStoreManagerImpl
     : public mojom::PrefStoreRegistry,
       public mojom::PrefStoreConnector,
       public service_manager::InterfaceFactory<mojom::PrefStoreConnector>,
       public service_manager::InterfaceFactory<mojom::PrefStoreRegistry>,
       public mojom::PrefServiceControl,
       public service_manager::InterfaceFactory<mojom::PrefServiceControl>,
       public service_manager::Service {
  public:
   // Only replies to Connect calls when all |expected_pref_stores| have
-  // registered.
+  // registered. |expected_pref_stores| must contain
+  // PrefValueStore::DEFAULT_STORE and PrefValueStore::USER_STORE for
+  // consistency, as the service always registers these
+  // internally. |worker_pool| is used for any I/O performed by the service.
   PrefStoreManagerImpl(
       std::set<PrefValueStore::PrefStoreType> expected_pref_stores,
       scoped_refptr<base::SequencedWorkerPool> worker_pool);
   ~PrefStoreManagerImpl() override;
 
  private:
-  using PrefStorePtrs =
-      std::unordered_map<PrefValueStore::PrefStoreType, mojom::PrefStorePtr>;
+  struct PendingConnect;
 
   // mojom::PrefStoreRegistry:
   void Register(PrefValueStore::PrefStoreType type,
                 mojom::PrefStorePtr pref_store_ptr) override;
 
-  // mojom::PrefStoreConnector:
-  void Connect(mojom::PrefRegistryPtr pref_registry,
-               const ConnectCallback& callback) override;
+  // mojom::PrefStoreConnector: |already_connected_types| must not include
+  // PrefValueStore::DEFAULT_STORE and PrefValueStore::USER_STORE as these must
+  // always be accessed through the service.
+  void Connect(
+      mojom::PrefRegistryPtr pref_registry,
+      const std::vector<PrefValueStore::PrefStoreType>& already_connected_types,
+      const ConnectCallback& callback) override;
 
   // service_manager::InterfaceFactory<PrefStoreConnector>:
   void Create(const service_manager::Identity& remote_identity,
               prefs::mojom::PrefStoreConnectorRequest request) override;
 
   // service_manager::InterfaceFactory<PrefStoreRegistry>:
   void Create(const service_manager::Identity& remote_identity,
               prefs::mojom::PrefStoreRegistryRequest request) override;
 
   // service_manager::InterfaceFactory<PrefServiceControl>:
   void Create(const service_manager::Identity& remote_identity,
               prefs::mojom::PrefServiceControlRequest request) override;
 
   // PrefServiceControl:
   void Init(mojom::PersistentPrefStoreConfigurationPtr configuration) override;
 
   // service_manager::Service:
   void OnStart() override;
   bool OnConnect(const service_manager::ServiceInfo& remote_info,
                  service_manager::InterfaceRegistry* registry) override;
 
   // Called when a PrefStore previously registered using |Register| disconnects.
   void OnPrefStoreDisconnect(PrefValueStore::PrefStoreType type);
 
   // Have all the expected PrefStores connected?
   bool AllConnected() const;
 
   void ProcessPendingConnects();
 
-  void ConnectImpl(mojom::PrefRegistryPtr pref_registry,
-                   const ConnectCallback& callback);
+  void ConnectImpl(
+      mojom::PrefRegistryPtr pref_registry,
+      const std::vector<PrefValueStore::PrefStoreType>& already_connected_types,
+      const ConnectCallback& callback);
 
   void OnPersistentPrefStoreReady();
 
-  // PrefStores that need to register before replying to any Connect calls.
+  // PrefStores that need to register before replying to any Connect calls. This
+  // does not include the PersistentPrefStore, which is handled separately.
   std::set<PrefValueStore::PrefStoreType> expected_pref_stores_;
 
   // Registered pref stores.
-  PrefStorePtrs pref_store_ptrs_;
+  std::unordered_map<PrefValueStore::PrefStoreType, mojom::PrefStorePtr>
+      pref_store_ptrs_;
 
   // We hold on to the connection request callbacks until all expected
   // PrefStores have registered.
-  std::vector<std::pair<ConnectCallback, mojom::PrefRegistryPtr>>
-      pending_connects_;
+  std::vector<PendingConnect> pending_connects_;
 
   mojo::BindingSet<mojom::PrefStoreConnector> connector_bindings_;
   mojo::BindingSet<mojom::PrefStoreRegistry> registry_bindings_;
   std::unique_ptr<PersistentPrefStoreImpl> persistent_pref_store_;
   mojo::Binding<mojom::PrefServiceControl> init_binding_;
 
   const scoped_refptr<DefaultPrefStore> defaults_;
   const std::unique_ptr<PrefStoreImpl> defaults_wrapper_;
 
   const scoped_refptr<base::SequencedWorkerPool> worker_pool_;
 
   DISALLOW_COPY_AND_ASSIGN(PrefStoreManagerImpl);
 };
 
 }  // namespace prefs
 
 #endif  // SERVICES_PREFERENCES_PREF_STORE_MANAGER_IMPL_H_