Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: ash/shell.cc

Issue 2791903003: Pref service: have Mash and Chrome connect to the right pref stores (Closed)
Patch Set: ProfilePrefStoreManagerTest: explicit list stores to connect to Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/prefs/active_profile_pref_service.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/shell.h" 5 #include "ash/shell.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 10
(...skipping 784 matching lines...) Expand 10 before | Expand all | Expand 10 after
795 795
796 wallpaper_delegate_ = shell_delegate_->CreateWallpaperDelegate(); 796 wallpaper_delegate_ = shell_delegate_->CreateWallpaperDelegate();
797 797
798 // Can be null in tests. 798 // Can be null in tests.
799 // TODO(jonross): reenable once the cause of crbug.com/707321 is determined. 799 // TODO(jonross): reenable once the cause of crbug.com/707321 is determined.
800 /* 800 /*
801 if (wm_shell_->IsRunningInMash() && shell_delegate_->GetShellConnector()) { 801 if (wm_shell_->IsRunningInMash() && shell_delegate_->GetShellConnector()) {
802 prefs::ConnectToPrefService( 802 prefs::ConnectToPrefService(
803 shell_delegate_->GetShellConnector(), 803 shell_delegate_->GetShellConnector(),
804 make_scoped_refptr(new PrefRegistrySimple()), 804 make_scoped_refptr(new PrefRegistrySimple()),
805 std::vector<PrefValueStore::PrefStoreType>(),
805 base::Bind(&Shell::OnPrefServiceInitialized, base::Unretained(this)), 806 base::Bind(&Shell::OnPrefServiceInitialized, base::Unretained(this)),
806 prefs::mojom::kForwarderServiceName); 807 prefs::mojom::kForwarderServiceName);
807 }*/ 808 }*/
808 809
809 // Some delegates access WmShell during their construction. Create them here 810 // Some delegates access WmShell during their construction. Create them here
810 // instead of the WmShell constructor. 811 // instead of the WmShell constructor.
811 accessibility_delegate_.reset(shell_delegate_->CreateAccessibilityDelegate()); 812 accessibility_delegate_.reset(shell_delegate_->CreateAccessibilityDelegate());
812 palette_delegate_ = shell_delegate_->CreatePaletteDelegate(); 813 palette_delegate_ = shell_delegate_->CreatePaletteDelegate();
813 toast_manager_ = base::MakeUnique<ToastManager>(); 814 toast_manager_ = base::MakeUnique<ToastManager>();
814 815
(...skipping 439 matching lines...) Expand 10 before | Expand all | Expand 10 after
1254 1255
1255 void Shell::OnPrefServiceInitialized( 1256 void Shell::OnPrefServiceInitialized(
1256 std::unique_ptr<::PrefService> pref_service) { 1257 std::unique_ptr<::PrefService> pref_service) {
1257 if (!instance_) 1258 if (!instance_)
1258 return; 1259 return;
1259 DCHECK(pref_service); 1260 DCHECK(pref_service);
1260 pref_service_ = std::move(pref_service); 1261 pref_service_ = std::move(pref_service);
1261 } 1262 }
1262 1263
1263 } // namespace ash 1264 } // namespace ash
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/prefs/active_profile_pref_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698