third_party/WebKit/Source/core/html/HTMLVideoElement.cpp - Issue 2791813003: Fix broken draw/upload paths from videos to 2D canvas and WebGL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

Issue 2791813003: Fix broken draw/upload paths from videos to 2D canvas and WebGL. (Closed)

Patch Set: Disable GPU-GPU copies to floating-point textures on Android. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

index 3bf2a9d4f7c1d68896882ad758f7047a794e1fac..2e741f235ebd59cc110384346367ecd92780ed6c 100644

--- a/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLVideoElement.cpp

@@ -310,13 +310,16 @@ void HTMLVideoElement::PaintCurrentFrame(PaintCanvas* canvas,

bool HTMLVideoElement::CopyVideoTextureToPlatformTexture(

gpu::gles2::GLES2Interface* gl,

GLuint texture,

+ GLenum internal_format,

+ GLenum format,

+ GLenum type,

bool premultiply_alpha,

bool flip_y) {

if (!GetWebMediaPlayer())

return false;

return GetWebMediaPlayer()->CopyVideoTextureToPlatformTexture(

- gl, texture, premultiply_alpha, flip_y);

+ gl, texture, internal_format, format, type, premultiply_alpha, flip_y);

}

bool HTMLVideoElement::TexImageImpl(