Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h

Issue 2791803002: mash: Move LauncherItemController to ash, rename ShelfItemDelegate. (Closed)
Patch Set: Sync and rebase. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h
diff --git a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h
index 321d01c322710955df53bf3edfa933af486fdcb2..e5066041800b9d050ba1476e5c2d49d0357cc320 100644
--- a/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h
+++ b/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h
@@ -16,13 +16,15 @@ class ChromeLauncherControllerMus : public ChromeLauncherController {
~ChromeLauncherControllerMus() override;
// ChromeLauncherController:
- ash::ShelfID CreateAppLauncherItem(LauncherItemController* controller,
- ash::ShelfItemStatus status) override;
+ ash::ShelfID CreateAppLauncherItem(
+ std::unique_ptr<ash::ShelfItemDelegate> item_delegate,
+ ash::ShelfItemStatus status) override;
const ash::ShelfItem* GetItem(ash::ShelfID id) const override;
void SetItemType(ash::ShelfID id, ash::ShelfItemType type) override;
void SetItemStatus(ash::ShelfID id, ash::ShelfItemStatus status) override;
- void SetItemController(ash::ShelfID id,
- LauncherItemController* controller) override;
+ void SetShelfItemDelegate(
+ ash::ShelfID id,
+ std::unique_ptr<ash::ShelfItemDelegate> item_delegate) override;
void CloseLauncherItem(ash::ShelfID id) override;
bool IsPinned(ash::ShelfID id) override;
void SetV1AppStatus(const std::string& app_id,
@@ -46,7 +48,8 @@ class ChromeLauncherControllerMus : public ChromeLauncherController {
bool allow_minimize) override;
void ActiveUserChanged(const std::string& user_email) override;
void AdditionalUserAddedToSession(Profile* profile) override;
- MenuItemList GetAppMenuItemsForTesting(const ash::ShelfItem& item) override;
+ ash::MenuItemList GetAppMenuItemsForTesting(
+ const ash::ShelfItem& item) override;
std::vector<content::WebContents*> GetV1ApplicationsFromAppId(
const std::string& app_id) override;
void ActivateShellApp(const std::string& app_id, int window_index) override;
@@ -59,8 +62,7 @@ class ChromeLauncherControllerMus : public ChromeLauncherController {
content::WebContents* web_contents) const override;
BrowserShortcutLauncherItemController*
GetBrowserShortcutLauncherItemController() override;
- LauncherItemController* GetLauncherItemController(
- const ash::ShelfID id) override;
+ ash::ShelfItemDelegate* GetShelfItemDelegate(const ash::ShelfID id) override;
bool ShelfBoundsChangesProbablyWithUser(
ash::WmShelf* shelf,
const AccountId& account_id) const override;

Powered by Google App Engine
This is Rietveld 408576698