Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: third_party/WebKit/public/web/WebSpellCheckClient.h

Issue 2791753003: Split WebTextCheckClient off WebSpellCheckClient (Closed)
Patch Set: Add TODOs for class renaming Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/BUILD.gn ('k') | third_party/WebKit/public/web/WebTextCheckClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebSpellCheckClient.h
diff --git a/third_party/WebKit/public/web/WebSpellCheckClient.h b/third_party/WebKit/public/web/WebSpellCheckClient.h
index 09707198820b6f014c7b17c3ee717f91913538d5..65a8b06492ee60ca96bb59d224af28e0a074b3af 100644
--- a/third_party/WebKit/public/web/WebSpellCheckClient.h
+++ b/third_party/WebKit/public/web/WebSpellCheckClient.h
@@ -31,37 +31,13 @@
#ifndef WebSpellCheckClient_h
#define WebSpellCheckClient_h
-#include "../platform/WebString.h"
-#include "../platform/WebVector.h"
+#include "public/platform/WebString.h"
namespace blink {
-class WebString;
-class WebTextCheckingCompletion;
-
+// TODO(xiaochengh): Renaming WebSpellCheckClient to WebSpellingUIClient.
class WebSpellCheckClient {
public:
- // The client should perform spell-checking on the given text. If the
- // text contains a misspelled word, then upon return misspelledOffset
- // will point to the start of the misspelled word, and misspelledLength
- // will indicates its length. Otherwise, if there was not a spelling
- // error, then upon return misspelledLength is 0. If optional_suggestions
- // is given, then it will be filled with suggested words (not a cheap step).
- virtual void checkSpelling(const WebString& text,
- int& misspelledOffset,
- int& misspelledLength,
- WebVector<WebString>* optionalSuggestions) {}
-
- // Requests asynchronous spelling and grammar checking, whose result should be
- // returned by passed completion object.
- virtual void requestCheckingOfText(
- const WebString& textToCheck,
- WebTextCheckingCompletion* completionCallback) {}
-
- // Clear all stored references to requests, so that it will not become a
- // leak source.
- virtual void cancelAllPendingRequests() {}
-
// Show or hide the spelling UI.
virtual void showSpellingUI(bool show) {}
@@ -72,7 +48,7 @@ class WebSpellCheckClient {
virtual void updateSpellingUIWithMisspelledWord(const WebString& word) {}
protected:
- ~WebSpellCheckClient() {}
+ virtual ~WebSpellCheckClient() {}
};
} // namespace blink
« no previous file with comments | « third_party/WebKit/public/BUILD.gn ('k') | third_party/WebKit/public/web/WebTextCheckClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698