Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 279173005: Revert 269798 "Only commit cookie changes in prerenders after a ..." (Closed)

Created:
6 years, 7 months ago by mmenke
Modified:
6 years, 7 months ago
Reviewers:
tburkard
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 269798 "Only commit cookie changes in prerenders after a ..." This broke prerender omnibox tests (Failing on tree, also failed on trybot runs for the CL). > Only commit cookie changes in prerenders after a prerender is shown > Will create a PrerenderCookieStore for each prerender, retaining all cookie > operations of a prerender until the prerender is shown to the user. > Forces prerenders to be in a new render process by themselves for this to work. > BUG=371003 > R=creis@chromium.org, davidben@chromium.org, erikwright@chromium.org, jam@chromium.org, jochen@chromium.org > > Review URL: https://codereview.chromium.org/233353003 TBR=tburkard@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1143 lines) Patch
M trunk/src/chrome/android/java/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandler.java View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java View 3 chunks +1 line, -7 lines 0 comments Download
M trunk/src/chrome/browser/chrome_content_browser_client.h View 4 chunks +0 lines, -16 lines 0 comments Download
M trunk/src/chrome/browser/chrome_content_browser_client.cc View 5 chunks +1 line, -39 lines 0 comments Download
M trunk/src/chrome/browser/extensions/activity_log/activity_log_browsertest.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/extensions/activity_log/activity_log_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/net/chrome_network_delegate.h View 3 chunks +0 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/net/chrome_network_delegate.cc View 4 chunks +1 line, -11 lines 0 comments Download
M trunk/src/chrome/browser/net/cookie_store_util.cc View 3 chunks +0 lines, -19 lines 0 comments Download
M trunk/src/chrome/browser/net/evicted_domain_cookie_counter.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/net/evicted_domain_cookie_counter.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/net/evicted_domain_cookie_counter_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/prerender/external_prerender_handler_android.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/prerender/external_prerender_handler_android.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/prerender/prerender_browsertest.cc View 3 chunks +0 lines, -119 lines 0 comments Download
M trunk/src/chrome/browser/prerender/prerender_contents.h View 3 chunks +2 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/prerender/prerender_contents.cc View 4 chunks +3 lines, -24 lines 0 comments Download
D trunk/src/chrome/browser/prerender/prerender_cookie_store.h View 1 chunk +0 lines, -164 lines 0 comments Download
D trunk/src/chrome/browser/prerender/prerender_cookie_store.cc View 1 chunk +0 lines, -241 lines 0 comments Download
M trunk/src/chrome/browser/prerender/prerender_final_status.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/prerender/prerender_final_status.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/prerender/prerender_manager.h View 6 chunks +0 lines, -37 lines 0 comments Download
M trunk/src/chrome/browser/prerender/prerender_manager.cc View 9 chunks +4 lines, -71 lines 0 comments Download
M trunk/src/chrome/browser/prerender/prerender_tracker.h View 3 chunks +1 line, -36 lines 0 comments Download
M trunk/src/chrome/browser/prerender/prerender_tracker.cc View 2 chunks +0 lines, -87 lines 0 comments Download
M trunk/src/chrome/browser/prerender/prerender_unittest.cc View 4 chunks +2 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_io_data.h View 2 chunks +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/profiles/profile_io_data.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/search/instant_search_prerenderer_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
D trunk/src/chrome/test/data/android/prerender/homepage.html View 1 chunk +0 lines, -12 lines 0 comments Download
D trunk/src/chrome/test/data/prerender/prerender_cookie.html View 1 chunk +0 lines, -41 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M trunk/src/content/public/browser/content_browser_client.h View 2 chunks +1 line, -5 lines 0 comments Download
M trunk/src/content/public/browser/content_browser_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/net/cookies/canonical_cookie.h View 3 chunks +0 lines, -9 lines 0 comments Download
M trunk/src/net/cookies/canonical_cookie.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M trunk/src/net/cookies/cookie_monster.h View 5 chunks +4 lines, -20 lines 0 comments Download
M trunk/src/net/cookies/cookie_monster.cc View 6 chunks +2 lines, -61 lines 0 comments Download
M trunk/src/net/cookies/cookie_monster_store_test.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/net/cookies/cookie_monster_store_test.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mmenke
6 years, 7 months ago (2014-05-12 18:03:24 UTC) #1
mmenke
6 years, 7 months ago (2014-05-12 18:05:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r269812 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698