Update GpuSurfaceTracker to include Android surfaces.

gpu/ipc/common/gpu_surface_tracker.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GPU_IPC_COMMON_GPU_SURFACE_TRACKER_H_
 #define GPU_IPC_COMMON_GPU_SURFACE_TRACKER_H_
 
 #include <stddef.h>
 
 #include <map>
 
 #include "base/macros.h"
 #include "base/memory/singleton.h"
 #include "base/synchronization/lock.h"
 #include "gpu/gpu_export.h"
 #include "gpu/ipc/common/gpu_surface_lookup.h"
 #include "gpu/ipc/common/surface_handle.h"
 #include "ui/gfx/native_widget_types.h"
 
 namespace gpu {
 
 // This class is used on Android and Mac, and is responsible for tracking native
 // window surfaces exposed to the GPU process. Every surface gets registered to
 // this class, and gets a handle.  The handle can be passed to
 // CommandBufferProxyImpl::Create or to
 // GpuMemoryBufferManager::CreateGpuMemoryBuffer.
 // On Android, the handle is used in the GPU process to get a reference to the
 // ANativeWindow, using GpuSurfaceLookup (implemented by
-// ChildProcessSurfaceManager).
+// ChildProcessSurfaceManager).  We require that an Android Surface is provided
+// with the ANativeWindow, so one must provide an explicit GpuSurfaceTracker::
+// Record when adding it.
 // On Mac, the handle just passes through the GPU process, and is sent back via
 // GpuCommandBufferMsg_SwapBuffersCompleted to reference the surface.
 // This class is thread safe.
 class GPU_EXPORT GpuSurfaceTracker : public gpu::GpuSurfaceLookup {
  public:
+  struct Record {
+#if defined(OS_ANDROID)
+    explicit Record(gfx::AcceleratedWidget widget, jobject j_surface);

[dcheng, 2017/04/14 00:55:24]

This doesn't need explicit

[liberato (no reviews please), 2017/04/18 20:47:38]

Done.

+#else   // !defined(OS_ANDROID)
+    // Not explicit, since one can just provide the AcceleratedWidget and let it
+    // auto-convert to Record.
+    Record(gfx::AcceleratedWidget widget);

[dcheng, 2017/04/14 00:55:24]

FWIW, this is specifically against the style guide.

This would also make Android and non-Android consistent with each other.

(If you really want this, I guess you could overload
AddSurfaceForNativeWidget... but there's few enough callsites that it shouldn't
be hard to fix this)

[liberato (no reviews please), 2017/04/18 20:47:38]

good point.  i've made the callers explicitly construct one of these objects and
pass it in.

+#endif  // !defined(OS_ANDROID)

[dcheng, 2017/04/14 00:55:24]

Nit: usually no ! here (since this usually describes what #if condition this is
closing)

[liberato (no reviews please), 2017/04/18 20:47:38]

Done, and elsewhere.

+
+    Record(Record&&);
+    Record(const Record&) = delete;
+
+    gfx::AcceleratedWidget widget;
+#if defined(OS_ANDROID)
+    gl::ScopedJavaSurface surface;
+#endif
+  };
+
   // GpuSurfaceLookup implementation:
   // Returns the native widget associated with a given surface_handle.
   // On Android, this adds a reference on the ANativeWindow.
   gfx::AcceleratedWidget AcquireNativeWidget(
       gpu::SurfaceHandle surface_handle) override;
 
 #if defined(OS_ANDROID)
-  void RegisterViewSurface(int surface_id, jobject j_surface);
-  void UnregisterViewSurface(int surface_id);
-  gl::ScopedJavaSurface AcquireJavaSurface(int surface_id) override;
+  gl::ScopedJavaSurface AcquireJavaSurface(
+      gpu::SurfaceHandle surface_handle) override;
 #endif
 
   // Gets the global instance of the surface tracker.
   static GpuSurfaceTracker* Get() { return GetInstance(); }
 
   // Adds a surface for a native widget. Returns the surface ID.
-  int AddSurfaceForNativeWidget(gfx::AcceleratedWidget widget);
+  int AddSurfaceForNativeWidget(Record record);
 
   // Return true if the surface handle is registered with the tracker.
   bool IsValidSurfaceHandle(gpu::SurfaceHandle surface_handle) const;
 
   // Removes a given existing surface.
   void RemoveSurface(gpu::SurfaceHandle surface_handle);
 
   // Returns the number of surfaces currently registered with the tracker.
   std::size_t GetSurfaceCount();
 
   // Gets the global instance of the surface tracker. Identical to Get(), but
   // named that way for the implementation of Singleton.
   static GpuSurfaceTracker* GetInstance();
 
  private:
-  typedef std::map<gpu::SurfaceHandle, gfx::AcceleratedWidget> SurfaceMap;
+  typedef std::map<gpu::SurfaceHandle, Record> SurfaceMap;

[dcheng, 2017/04/14 00:55:24]

Nit using SurfaceMap = ...;

since this is changing anyway?

[liberato (no reviews please), 2017/04/18 20:47:38]

Done.

 
   friend struct base::DefaultSingletonTraits<GpuSurfaceTracker>;
 
   GpuSurfaceTracker();
   ~GpuSurfaceTracker() override;
 
   mutable base::Lock surface_map_lock_;
   SurfaceMap surface_map_;
   int next_surface_handle_;
 
-#if defined(OS_ANDROID)
-  base::Lock surface_view_map_lock_;
-  typedef std::map<gpu::SurfaceHandle, gl::ScopedJavaSurface> SurfaceViewMap;
-  SurfaceViewMap surface_view_map_;
-#endif
-
   DISALLOW_COPY_AND_ASSIGN(GpuSurfaceTracker);
 };
 
 }  // namespace ui
 
 #endif  // GPU_IPC_COMMON_GPU_SURFACE_TRACKER_H_