Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2791643003: Don't format on DDC presubmit (Closed)

Created:
3 years, 8 months ago by vsm
Modified:
3 years, 8 months ago
Reviewers:
Jacob
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't format on DDC presubmit The primary presubmit (PRESUBMIT.py) now enforces this on git cl upload. It also uses a difference version of the formatter, so dropping this avoids that annoyance. R=jacobr@google.com Committed: https://github.com/dart-lang/sdk/commit/3be5099a8cea98e9d813fb265622dc0adc131a20

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M pkg/dev_compiler/tool/presubmit.sh View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
3 years, 8 months ago (2017-03-31 20:34:46 UTC) #3
Jacob
lgtm
3 years, 8 months ago (2017-03-31 21:09:58 UTC) #4
vsm
3 years, 8 months ago (2017-03-31 22:06:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3be5099a8cea98e9d813fb265622dc0adc131a20 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698