chrome/browser/generic_sensor/OWNERS - Issue 2791623004: [sensors][permission] Add new permission types in permission module.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/generic_sensor/OWNERS

Issue 2791623004: [sensors][permission] Add new permission types in permission module. (Closed)

Patch Set: Fix owners Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 file://services/device/generic_sensor/OWNERS

	2 per-file permission_context=set noparent
	jochen (gone - plz use gerrit) 2017/07/25 15:21:25 Why noparent? Why noparent? raymes 2017/07/26 00:47:18 Modifying permission_context classes has potential Show quoted text On 2017/07/25 15:21:25, jochen (gone - plz use gerrit) wrote: > Why noparent? Modifying permission_context classes has potential security implications so we're requiring a review by enamel team for modifications to those classes. This allows the subclasses to live with the feature-specific code but get the appropriate review. riju_ 2017/08/01 12:09:33 Reference: https://codereview.chromium.org/2969393 Show quoted text On 2017/07/26 00:47:18, raymes wrote: > On 2017/07/25 15:21:25, jochen (gone - plz use gerrit) wrote: > > Why noparent? > > Modifying permission_context classes has potential security implications so > we're requiring a review by enamel team for modifications to those classes. This > allows the subclasses to live with the feature-specific code but get the > appropriate review. Reference: https://codereview.chromium.org/2969393002
	3 per-file

	4 permission_context=file://chrome/browser/permissions/PERMISSIONS_OWNERS

	5 # COMPONENT: Blink>Sensor

	6 # TEAM: device-dev@chromium.org

OLD	NEW

« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/generic_sensor/sensor_permission_context.h » ('j') | no next file with comments »