[Instrumentation Test Speed] Install apks in parallel with concurrent_adb enabled

build/android/pylib/local/device/local_device_instrumentation_test_run.py

Index: build/android/pylib/local/device/local_device_instrumentation_test_run.py
diff --git a/build/android/pylib/local/device/local_device_instrumentation_test_run.py b/build/android/pylib/local/device/local_device_instrumentation_test_run.py
index a8d9f5e6737828ccf5010f9070d4cdb553f407dd..b41ab50c9e45f9049d234e495b82ee2947690e1b 100644
--- a/build/android/pylib/local/device/local_device_instrumentation_test_run.py
+++ b/build/android/pylib/local/device/local_device_instrumentation_test_run.py
@@ -75,30 +75,36 @@ class LocalDeviceInstrumentationTestRun(
         self._env.BlacklistDevice)
     @trace_event.traced
     def individual_device_set_up(dev, host_device_tuples):
-      def install_apk():
-        if self._test_instance.apk_under_test:
-          if self._test_instance.apk_under_test_incremental_install_script:
-            local_device_test_run.IncrementalInstall(
-                dev,
-                self._test_instance.apk_under_test,
-                self._test_instance.apk_under_test_incremental_install_script)
-          else:
-            permissions = self._test_instance.apk_under_test.GetPermissions()
-            dev.Install(self._test_instance.apk_under_test,
-                        permissions=permissions)
-
-        if self._test_instance.test_apk_incremental_install_script:
-          local_device_test_run.IncrementalInstall(
-              dev,
-              self._test_instance.test_apk,
-              self._test_instance.test_apk_incremental_install_script)
+      steps = []
+      def install_helper(apk, permissions):
+        return lambda: dev.Install(apk, permissions=permissions)

[mikecase (-- gone --), 2017/04/08 00:50:12]

super nit: I think you should put empty line after install_helper() definition

[shenghuazhang, 2017/04/08 01:29:35]

Done.

+      if self._test_instance.apk_under_test:
+        if self._test_instance.apk_under_test_incremental_install_script:
+          steps.append(lambda: local_device_test_run.IncrementalInstall(
+                                   dev,
+                                   self._test_instance.apk_under_test,
+                                   self._test_instance.
+                                   apk_under_test_incremental_install_script))

[mikecase (-- gone --), 2017/04/08 00:50:12]

nit: i think this line should be intented more than the line above it. Not sure
if that pushes it above 80 chars. If so, you might have to put lambda on a new
line.

[shenghuazhang, 2017/04/08 01:29:35]

This change pushes above 80 characters. Will move the lambda to a new line.

         else:
-          permissions = self._test_instance.test_apk.GetPermissions()
-          dev.Install(self._test_instance.test_apk, permissions=permissions)
+          permissions = self._test_instance.apk_under_test.GetPermissions()
+          steps.append(install_helper(self._test_instance.apk_under_test,
+                                      permissions))
+
+      if self._test_instance.test_apk_incremental_install_script:
+        steps.append(lambda: local_device_test_run.IncrementalInstall(
+                                 dev,
+                                 self._test_instance.test_apk,
+                                 self._test_instance.
+                                 test_apk_incremental_install_script))

[mikecase (-- gone --), 2017/04/08 00:50:12]

nit: i think this line should be intented more than the line above it. Not sure
if that pushes it above 80 chars. If so, you might have to put lambda on a new
line.

[shenghuazhang, 2017/04/08 01:29:35]

This one is fine.

+      else:
+        permissions = self._test_instance.test_apk.GetPermissions()
+        steps.append(install_helper(self._test_instance.test_apk,
+                                    permissions))
 
-        for apk in self._test_instance.additional_apks:
-          dev.Install(apk)
+      steps.extend([install_helper(apk, None)
+                    for apk in self._test_instance.additional_apks])
 
+      def set_debug_app():
         # Set debug app in order to enable reading command line flags on user
         # builds
         if self._test_instance.flags:
@@ -165,8 +171,8 @@ class LocalDeviceInstrumentationTestRun(
         valgrind_tools.SetChromeTimeoutScale(
             dev, self._test_instance.timeout_scale)
 
-      steps = (install_apk, edit_shared_prefs, push_test_data,
-               create_flag_changer)
+      steps += [set_debug_app, edit_shared_prefs, push_test_data,
+                create_flag_changer]
       if self._env.concurrent_adb:
         reraiser_thread.RunAsync(steps)
       else: