Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3040)

Unified Diff: chrome/installer/util/BUILD.gn

Issue 2791593002: Allow installer::GetLocalizedString to return mode-specific strings. (Closed)
Patch Set: manzagop review part the deux Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/install_static/google_chrome_install_modes.h ('k') | chrome/installer/util/browser_distribution.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/BUILD.gn
diff --git a/chrome/installer/util/BUILD.gn b/chrome/installer/util/BUILD.gn
index 26ad3a003b5b2ecc62890dec982c41074d99c239..8d04ce75b23509bb956123c3ac77aa5f1f01ccc3 100644
--- a/chrome/installer/util/BUILD.gn
+++ b/chrome/installer/util/BUILD.gn
@@ -156,8 +156,6 @@ static_library("with_no_strings") {
"duplicate_tree_detector.h",
"firewall_manager_win.cc",
"firewall_manager_win.h",
- "google_chrome_sxs_distribution.cc",
- "google_chrome_sxs_distribution.h",
"google_update_constants.cc",
"google_update_constants.h",
"google_update_settings.cc",
@@ -243,6 +241,8 @@ action("generate_strings") {
]
args = [
+ "-b",
+ "$branding_path_component",
"-i",
rebase_path(grdfile, root_build_dir) + ":resources",
"-n",
@@ -293,6 +293,7 @@ if (is_win) {
"install_util_unittest.cc",
"installer_util_test_common.cc",
"installer_util_test_common.h",
+ "l10n_string_util_unittest.cc",
"language_selector_unittest.cc",
"legacy_firewall_manager_win_unittest.cc",
"logging_installer_unittest.cc",
« no previous file with comments | « chrome/install_static/google_chrome_install_modes.h ('k') | chrome/installer/util/browser_distribution.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698