Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8876)

Unified Diff: chrome/common/extensions/chrome_extension_messages.h

Issue 2791533002: Convert Web Store Inline Install IPCs to mojo (Closed)
Patch Set: Addressed Devlin's comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/BUILD.gn ('k') | chrome/common/extensions/mojom/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/chrome_extension_messages.h
diff --git a/chrome/common/extensions/chrome_extension_messages.h b/chrome/common/extensions/chrome_extension_messages.h
index e3aaf6f2b35ce18c77cf138e586760c99ac7a43e..b33eb8f42646c59f9c28820f07271228b1f151ae 100644
--- a/chrome/common/extensions/chrome_extension_messages.h
+++ b/chrome/common/extensions/chrome_extension_messages.h
@@ -29,6 +29,8 @@
#define IPC_MESSAGE_START ChromeExtensionMsgStart
+// TODO(crbug.com/725275): Remove these ipc enums once all ipc messages here are
+// converted to mojo.
IPC_ENUM_TRAITS_MAX_VALUE(extensions::api::webstore::InstallStage,
extensions::api::webstore::INSTALL_STAGE_INSTALLING)
IPC_ENUM_TRAITS_MAX_VALUE(extensions::webstore_install::Result,
@@ -36,24 +38,6 @@ IPC_ENUM_TRAITS_MAX_VALUE(extensions::webstore_install::Result,
// Messages sent from the browser to the renderer.
-// Sent to the renderer if install stage updates were requested for an inline
-// install.
-IPC_MESSAGE_ROUTED1(ExtensionMsg_InlineInstallStageChanged,
- extensions::api::webstore::InstallStage /* stage */)
-
-// Sent to the renderer if download progress updates were requested for an
-// inline install.
-IPC_MESSAGE_ROUTED1(ExtensionMsg_InlineInstallDownloadProgress,
- int /* percent_downloaded */)
-
-// Send to renderer once the installation mentioned on
-// ExtensionHostMsg_InlineWebstoreInstall is complete.
-IPC_MESSAGE_ROUTED4(ExtensionMsg_InlineWebstoreInstallResponse,
- int32_t /* install id */,
- bool /* whether the install was successful */,
- std::string /* error */,
- extensions::webstore_install::Result /* result */)
-
IPC_STRUCT_TRAITS_BEGIN(ui::AXNodeData)
IPC_STRUCT_TRAITS_MEMBER(id)
IPC_STRUCT_TRAITS_MEMBER(role)
@@ -140,12 +124,3 @@ IPC_MESSAGE_ROUTED2(ExtensionMsg_AccessibilityEvent,
IPC_MESSAGE_ROUTED1(ExtensionMsg_AccessibilityLocationChange,
ExtensionMsg_AccessibilityLocationChangeParams)
-// Messages sent from the renderer to the browser.
-
-
-// Sent by the renderer to implement chrome.webstore.install().
-IPC_MESSAGE_ROUTED4(ExtensionHostMsg_InlineWebstoreInstall,
- int32_t /* install id */,
- int32_t /* return route id */,
- std::string /* Web Store item ID */,
- int /* listeners_mask */)
« no previous file with comments | « chrome/common/extensions/BUILD.gn ('k') | chrome/common/extensions/mojom/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698