Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4512)

Unified Diff: chrome/renderer/extensions/webstore_bindings.h

Issue 2791533002: Convert Web Store Inline Install IPCs to mojo (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/webstore_bindings.h
diff --git a/chrome/renderer/extensions/webstore_bindings.h b/chrome/renderer/extensions/webstore_bindings.h
index 641fddd50888c3bbfd34d38102484fdbb2814111..06b0c9d4f5e5ceedc1d5786a8e10a9d989803840 100644
--- a/chrome/renderer/extensions/webstore_bindings.h
+++ b/chrome/renderer/extensions/webstore_bindings.h
@@ -7,6 +7,8 @@
#include "base/compiler_specific.h"
#include "base/macros.h"
+#include "chrome/common/extensions/mojo/inline_install.mojom.h"
+#include "chrome/common/extensions/mojo/inline_install_status.mojom.h"
#include "chrome/common/extensions/webstore_install_result.h"
#include "chrome/renderer/extensions/chrome_v8_extension_handler.h"
#include "extensions/renderer/object_backed_native_handler.h"
@@ -21,24 +23,31 @@ namespace extensions {
// allows JavaScript to initiate inline installs of apps that are listed in the
// Chrome Web Store (CWS).
class WebstoreBindings : public ObjectBackedNativeHandler,
- public ChromeV8ExtensionHandler {
+ public ChromeV8ExtensionHandler,
+ public mojom::InlineInstallStatus {
public:
explicit WebstoreBindings(ScriptContext* context);
+ ~WebstoreBindings() override;
// IPC::Listener
bool OnMessageReceived(const IPC::Message& message) override;
+ static void BindInlineInstallStatusRequest(
+ ScriptContext* context,
+ mojom::InlineInstallStatusRequest request);
+
private:
void Install(const v8::FunctionCallbackInfo<v8::Value>& args);
- void OnInlineWebstoreInstallResponse(int install_id,
- bool success,
- const std::string& error,
- webstore_install::Result result);
+ // mojom::InlineInstallStatus
+ void InlineWebstoreInstallResponse(int install_id,
+ bool success,
+ const std::string& error,
+ webstore_install::Result result) override;
- void OnInlineInstallStageChanged(int stage);
+ void InlineInstallStageChanged(api::webstore::InstallStage stage) override;
- void OnInlineInstallDownloadProgress(int percent_downloaded);
+ void InlineInstallDownloadProgress(int percent_downloaded) override;
// Extracts a Web Store item ID from a <link rel="chrome-webstore-item"
// href="https://chrome.google.com/webstore/detail/id"> node found in the
@@ -51,6 +60,8 @@ class WebstoreBindings : public ObjectBackedNativeHandler,
std::string* webstore_item_id,
std::string* error);
+ extensions::mojom::InlineInstallPtr inline_install_;
+
DISALLOW_COPY_AND_ASSIGN(WebstoreBindings);
};

Powered by Google App Engine
This is Rietveld 408576698