chrome/common/extensions/mojo/inline_install_status.mojom - Issue 2791533002: Convert Web Store Inline Install IPCs to mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/common/extensions/mojo/inline_install_status.mojom

Issue 2791533002: Convert Web Store Inline Install IPCs to mojo (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/chrome_extension_messages.h ('K') | « chrome/common/extensions/mojo/inline_install.mojom ('k') | chrome/common/extensions/mojo/inline_install_status.typemap » ('j') | chrome/renderer/extensions/webstore_bindings.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 module extensions.mojom;

	6

	7 [Native]

	8 enum WebstoreInstallStage;

	9

	10 [Native]

	11 enum WebstoreInstallResult;

	12

	13 interface InlineInstallStatus {
	Devlin 2017/03/31 14:18:39 Any reason to not combine this with the other mojo Any reason to not combine this with the other mojom? catmullings 2017/04/06 20:50:15 Done. Show quoted text On 2017/03/31 14:18:39, Devlin wrote: > Any reason to not combine this with the other mojom? Done.
	14 // Notifies the renderer once the installation mentioned on

	15 // InlineWebstoreInstall is complete.

	16 InlineWebstoreInstallResponse(int32 install_id, bool success, string error,
	Devlin 2017/03/31 14:18:39 One of the advantages of mojo is that it can provi One of the advantages of mojo is that it can provide a callback for methods that used to need to do a call -> response pattern. That way, you can pass the callback directly in and just run it when the task completes. So for this, we could do something like: DoInlineInstall(...) => (int32 install_id, bool success, string error, WebStoreInstallResult result) and omit the InlineWebstoreInstallResponse message. catmullings 2017/04/06 20:50:15 Done. Show quoted text On 2017/03/31 14:18:39, Devlin wrote: > One of the advantages of mojo is that it can provide a callback for methods that > used to need to do a call -> response pattern. That way, you can pass the > callback directly in and just run it when the task completes. > > So for this, we could do something like: > DoInlineInstall(...) => (int32 install_id, bool success, string error, > WebStoreInstallResult result) > and omit the InlineWebstoreInstallResponse message. Done.
	17 WebstoreInstallResult result);

	18

	19 // Notifies the renderer when install stage updates were requested for an

	20 // inline install.

	21 InlineInstallStageChanged(WebstoreInstallStage stage);

	22

	23 // Notifies the renderer when download progress updates were requested for an

	24 // inline install.

	25 InlineInstallDownloadProgress(int32 percent_downloaded);

	26 };

	27

OLD	NEW