Convert Web Store Inline Install IPCs to mojo

chrome/common/extensions/chrome_extension_messages.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Chrome-specific IPC messages for extensions.
 // Extension-related messages that aren't specific to Chrome live in
 // extensions/common/extension_messages.h.
 //
 // Multiply-included message file, hence no include guard.
 
@@ skipping 13 matching lines @@
 #include "ui/accessibility/ax_relative_bounds.h"
 #include "ui/accessibility/ax_tree_data.h"
 #include "ui/accessibility/ax_tree_update.h"
 #include "ui/gfx/transform.h"
 #include "url/gurl.h"
 
 #define IPC_MESSAGE_START ChromeExtensionMsgStart
 
 IPC_ENUM_TRAITS_MAX_VALUE(extensions::api::webstore::InstallStage,
                           extensions::api::webstore::INSTALL_STAGE_INSTALLING)
 IPC_ENUM_TRAITS_MAX_VALUE(extensions::webstore_install::Result,

[catmullings, 2017/03/31 00:08:21]

Can these IPC_ENUMs be removed? They've been redefined in
chrome/common/extensions/mojo/inline_install_traits.h in this CL. Despite the
redefinition, deleting them here poses a linker error. e.g:

/mojo/public/cpp/bindings/lib/native_enum_serialization.h:34: error: undefined
reference to 'IPC::ParamTraits<extensions::api::webstore::InstallStage>::Write

... so right now, these IPC_ENUMs been preserved. 

[Devlin, 2017/03/31 14:18:39]

Hmm... the [native] tag on the mojo equivalents means that mojo should reuse
existing IPC_ENUM_TRAITS declarations. I see that they're added to
inline_install_traits.h, but inline_install_traits.h isn't being included in any
build targets.  Perhaps it's not being built, since I think the [traits_headers]
is typically used to define struct traits?  That's just wild guessing, though. 
Do you know of other ipc enums that use this pattern?

[catmullings, 2017/04/06 20:50:15]

I think you are right that inline_install_traits.h should be added to a build
target, which I have now done (see chrome/common/BUILD.gn). However, the same
linker error persists. Once all the IPCs in this file are converted, I'll
revisit removing these IPC enums.

                           extensions::webstore_install::RESULT_LAST)
 
 // Messages sent from the browser to the renderer.
 
-// Sent to the renderer if install stage updates were requested for an inline
-// install.
-IPC_MESSAGE_ROUTED1(ExtensionMsg_InlineInstallStageChanged,
-                    extensions::api::webstore::InstallStage /* stage */)
-
-// Sent to the renderer if download progress updates were requested for an
-// inline install.
-IPC_MESSAGE_ROUTED1(ExtensionMsg_InlineInstallDownloadProgress,
-                    int /* percent_downloaded */)
-
-// Send to renderer once the installation mentioned on
-// ExtensionHostMsg_InlineWebstoreInstall is complete.
-IPC_MESSAGE_ROUTED4(ExtensionMsg_InlineWebstoreInstallResponse,
-                    int32_t /* install id */,
-                    bool /* whether the install was successful */,
-                    std::string /* error */,
-                    extensions::webstore_install::Result /* result */)
-
 IPC_STRUCT_TRAITS_BEGIN(ui::AXNodeData)
   IPC_STRUCT_TRAITS_MEMBER(id)
   IPC_STRUCT_TRAITS_MEMBER(role)
   IPC_STRUCT_TRAITS_MEMBER(state)
   IPC_STRUCT_TRAITS_MEMBER(location)
   IPC_STRUCT_TRAITS_MEMBER(transform)
   IPC_STRUCT_TRAITS_MEMBER(string_attributes)
   IPC_STRUCT_TRAITS_MEMBER(int_attributes)
   IPC_STRUCT_TRAITS_MEMBER(float_attributes)
   IPC_STRUCT_TRAITS_MEMBER(bool_attributes)
@@ skipping 69 matching lines @@
 IPC_MESSAGE_ROUTED2(ExtensionMsg_AccessibilityEvent,
                     ExtensionMsg_AccessibilityEventParams,
                     bool /* is_active_profile */)
 
 // Forward an accessibility location change message to an extension process
 // where an extension is using the automation API to listen for
 // accessibility events.
 IPC_MESSAGE_ROUTED1(ExtensionMsg_AccessibilityLocationChange,
                     ExtensionMsg_AccessibilityLocationChangeParams)
 
-// Messages sent from the renderer to the browser.
-
-
-// Sent by the renderer to implement chrome.webstore.install().
-IPC_MESSAGE_ROUTED4(ExtensionHostMsg_InlineWebstoreInstall,
-                    int32_t /* install id */,
-                    int32_t /* return route id */,
-                    std::string /* Web Store item ID */,
-                    int /* listeners_mask */)