Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2791453002: Revert "[dart:io] Adds Platform.localeName" (Closed)

Created:
3 years, 8 months ago by zra
Modified:
3 years, 8 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "[dart:io] Adds Platform.localeName" This reverts commit ae6d854ec6134bda2f64d2747b5cd9b534c5bb04. The build failed on the mac build bots. Need to investigate. Committed: https://github.com/dart-lang/sdk/commit/e75df3cce3657d4d2ab609325a902809fe8ef4c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -150 lines) Patch
M CHANGELOG.md View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/patch/io_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/bin/io_natives.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/platform.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/bin/platform.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/bin/platform_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/platform_fuchsia.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/platform_linux.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/bin/platform_macos.cc View 2 chunks +0 lines, -56 lines 0 comments Download
M runtime/bin/platform_patch.dart View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/bin/platform_unsupported.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M runtime/bin/platform_win.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/io_patch.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M sdk/lib/io/platform.dart View 2 chunks +0 lines, -6 lines 0 comments Download
M sdk/lib/io/platform_impl.dart View 1 chunk +0 lines, -13 lines 0 comments Download
D tests/standalone/io/locale_name_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
TBR
3 years, 8 months ago (2017-03-30 20:34:49 UTC) #2
zra
Committed patchset #1 (id:1) manually as e75df3cce3657d4d2ab609325a902809fe8ef4c7 (presubmit successful).
3 years, 8 months ago (2017-03-30 20:35:09 UTC) #4
Florian Schneider
3 years, 8 months ago (2017-03-30 20:36:39 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698