Fix Border collapsing with colpsan / rowspan cells

third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc.
  *               All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  *
@@ skipping 1050 matching lines @@
   }
 }
 
 void LayoutTableSection::DistributeRemainingExtraLogicalHeight(
     int& extra_logical_height) {
   unsigned total_rows = grid_.size();
 
   if (extra_logical_height <= 0 || !row_pos_[total_rows])
     return;
 
-  // FIXME: m_rowPos[totalRows] - m_rowPos[0] is the total rows' size.
+  // FIXME: row_pos_[totalRows] - row_pos_[0] is the total rows' size.
   int total_row_size = row_pos_[total_rows];
   int total_logical_height_added = 0;
   int previous_row_position = row_pos_[0];
   for (unsigned r = 0; r < total_rows; r++) {
     // weight with the original height
     total_logical_height_added += extra_logical_height *
                                   (row_pos_[r + 1] - previous_row_position) /
                                   total_row_size;
     previous_row_position = row_pos_[r + 1];
     row_pos_[r + 1] += total_logical_height_added;
@@ skipping 1075 matching lines @@
   if (Table()->Header() == this && IsRepeatingHeaderGroup()) {
     transform_state.Flatten();
     FloatRect rect = transform_state.LastPlanarQuad().BoundingBox();
     rect.SetHeight(Table()->LogicalHeight());
     transform_state.SetQuad(FloatQuad(rect));
   }
   return LayoutTableBoxComponent::MapToVisualRectInAncestorSpaceInternal(
       ancestor, transform_state, flags);
 }
 
-bool LayoutTableSection::PaintedOutputOfObjectHasNoEffectRegardlessOfSize()
-    const {
-  // LayoutTableSection paints background from columns.
-  if (Table()->HasColElements())
-    return false;
-  return LayoutTableBoxComponent::
-      PaintedOutputOfObjectHasNoEffectRegardlessOfSize();
+LayoutRect LayoutTableSection::GetCellPosition(
+    unsigned row,
+    unsigned effective_column) const {
+  LayoutTable* table = this->Table();
+  LayoutUnit left =
+      LayoutUnit(table->EffectiveColumnPositions()[effective_column]);
+  LayoutUnit top = LayoutUnit(row_pos_[row]);
+  unsigned rightCol = std::min<unsigned>(
+      table->EffectiveColumnPositions().size() - 1, effective_column + 1);
+  unsigned bottom_row = std::min<unsigned>(row_pos_.size() - 1, row + 1);
+  LayoutUnit right = LayoutUnit(table->EffectiveColumnPositions()[rightCol]);
+  LayoutUnit bottom = LayoutUnit(row_pos_[bottom_row]);
+  left += LayoutUnit(table->HBorderSpacing());
+  return LayoutRect(left, top, right - left, bottom - top);
+}
+
+LayoutRect LayoutTableSection::GetCellPhysicalPosition(
+    unsigned row,
+    unsigned effective_column) const {
+  return TransformLogicalToPhysicalPosition(
+      GetCellPosition(row, effective_column));
+}
+
+LayoutRect LayoutTableSection::TransformLogicalToPhysicalPosition(
+    const LayoutRect& position) const {
+  WritingMode writingMode = Style()->GetWritingMode();
+  bool is_ltr = Style()->IsLeftToRightDirection();
+  LayoutRect transformed_position = position;
+  if (blink::IsHorizontalWritingMode(writingMode)) {
+    if (!is_ltr)
+      transformed_position.SetX(Size().Width() - transformed_position.MaxX());
+  } else {
+    transformed_position = transformed_position.TransposedRect();
+    if (!is_ltr)
+      transformed_position.SetY(Size().Height() - transformed_position.MaxY());
+    if (blink::IsFlippedBlocksWritingMode(writingMode))
+      transformed_position.SetX(Size().Width() - transformed_position.MaxX());
+  }
+  return transformed_position;
 }
 
 }  // namespace blink