Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3930)

Unified Diff: chrome/common/extensions/api/app_window.idl

Issue 279143002: Add some doco to app window onClosed event explaining how to use it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Better Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/app_window.idl
diff --git a/chrome/common/extensions/api/app_window.idl b/chrome/common/extensions/api/app_window.idl
index daf90f438f75347027a85e9cb5198c35b13d5d3d..1303385249f6b14316cfa871787b772c460033ee 100644
--- a/chrome/common/extensions/api/app_window.idl
+++ b/chrome/common/extensions/api/app_window.idl
@@ -411,7 +411,11 @@ namespace app.window {
// Fired when the window is resized.
[nocompile] static void onBoundsChanged();
- // Fired when the window is closed.
+ // Fired when the window is closed. Note, this should be listened to from
+ // a window other than the window being closed, for example from the
+ // background page. This is because the window being closed will be in the
+ // process of being torn down when the event is fired, which means not all
+ // APIs in the window's script context will be functional.
[nocompile] static void onClosed();
// Fired when the window is fullscreened.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698