Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: base/task_scheduler/task_scheduler.cc

Issue 2791423003: Initialize TaskScheduler with InitParams in CreateAndSetSimpleTaskScheduler(). (Closed)
Patch Set: CR Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/task_scheduler/task_scheduler.h" 5 #include "base/task_scheduler/task_scheduler.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 22 matching lines...) Expand all
33 background_blocking_worker_pool_params_in), 33 background_blocking_worker_pool_params_in),
34 foreground_worker_pool_params(foreground_worker_pool_params_in), 34 foreground_worker_pool_params(foreground_worker_pool_params_in),
35 foreground_blocking_worker_pool_params( 35 foreground_blocking_worker_pool_params(
36 foreground_blocking_worker_pool_params_in) {} 36 foreground_blocking_worker_pool_params_in) {}
37 37
38 TaskScheduler::InitParams::~InitParams() = default; 38 TaskScheduler::InitParams::~InitParams() = default;
39 39
40 #if !defined(OS_NACL) 40 #if !defined(OS_NACL)
41 // static 41 // static
42 void TaskScheduler::CreateAndSetSimpleTaskScheduler(const std::string& name) { 42 void TaskScheduler::CreateAndSetSimpleTaskScheduler(const std::string& name) {
43 constexpr int kMinNumThreads = 1; 43 using StandbyThreadPolicy = SchedulerWorkerPoolParams::StandbyThreadPolicy;
44 std::vector<SchedulerWorkerPoolParams> worker_pool_params_vector; 44
45 worker_pool_params_vector.emplace_back( 45 const int num_cores = SysInfo::NumberOfProcessors();
robliao 2017/04/06 18:09:37 Add a quick blurb on how we set these values: Inte
fdoray 2017/04/06 18:22:27 Done.
46 name, ThreadPriority::NORMAL, 46 constexpr int kBackgroundMaxThreads = 1;
47 SchedulerWorkerPoolParams::StandbyThreadPolicy::LAZY, 47 constexpr int kBackgroundBlockingMaxThreads = 2;
48 std::max(kMinNumThreads, SysInfo::NumberOfProcessors()), 48 const int kForegroundMaxThreads = std::max(1, num_cores);
49 TimeDelta::FromSeconds(30)); 49 const int kForegroundBlockingMaxThreads = std::max(2, num_cores);
50 constexpr TimeDelta kSuggestedReclaimTime = TimeDelta::FromSeconds(30);
51
50 CreateAndSetDefaultTaskScheduler( 52 CreateAndSetDefaultTaskScheduler(
51 worker_pool_params_vector, 53 name, {{StandbyThreadPolicy::LAZY, kBackgroundMaxThreads,
52 Bind([](const TaskTraits&) -> size_t { return 0; })); 54 kSuggestedReclaimTime},
55 {StandbyThreadPolicy::LAZY, kBackgroundBlockingMaxThreads,
56 kSuggestedReclaimTime},
57 {StandbyThreadPolicy::LAZY, kForegroundMaxThreads,
58 kSuggestedReclaimTime},
59 {StandbyThreadPolicy::LAZY, kForegroundBlockingMaxThreads,
60 kSuggestedReclaimTime}});
53 } 61 }
54 #endif // !defined(OS_NACL) 62 #endif // !defined(OS_NACL)
55 63
56 // static 64 // static
57 void TaskScheduler::CreateAndSetDefaultTaskScheduler( 65 void TaskScheduler::CreateAndSetDefaultTaskScheduler(
58 const std::vector<SchedulerWorkerPoolParams>& worker_pool_params_vector, 66 const std::vector<SchedulerWorkerPoolParams>& worker_pool_params_vector,
59 const WorkerPoolIndexForTraitsCallback& 67 const WorkerPoolIndexForTraitsCallback&
60 worker_pool_index_for_traits_callback) { 68 worker_pool_index_for_traits_callback) {
61 SetInstance(internal::TaskSchedulerImpl::Create( 69 SetInstance(internal::TaskSchedulerImpl::Create(
62 worker_pool_params_vector, worker_pool_index_for_traits_callback)); 70 worker_pool_params_vector, worker_pool_index_for_traits_callback));
(...skipping 10 matching lines...) Expand all
73 delete g_task_scheduler; 81 delete g_task_scheduler;
74 g_task_scheduler = task_scheduler.release(); 82 g_task_scheduler = task_scheduler.release();
75 } 83 }
76 84
77 // static 85 // static
78 TaskScheduler* TaskScheduler::GetInstance() { 86 TaskScheduler* TaskScheduler::GetInstance() {
79 return g_task_scheduler; 87 return g_task_scheduler;
80 } 88 }
81 89
82 } // namespace base 90 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698