Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: ios/web_view/internal/web_view_web_client.h

Issue 2791403005: Remove CWV class and move setting User Agent to CWVWebViewConfiguration. (Closed)
Patch Set: Move Browser State and Web Client ownership to CWVWebViewConfiguration. Each CWVWebViewConfiguratio… Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web_view/internal/web_view_web_client.h
diff --git a/ios/web_view/internal/web_view_web_client.h b/ios/web_view/internal/web_view_web_client.h
index 22b657dfcaea20e9a3fbead7d5055d9538e75b42..15f038f939c1f502349e6cae79e781f4dd4ef9c9 100644
--- a/ios/web_view/internal/web_view_web_client.h
+++ b/ios/web_view/internal/web_view_web_client.h
@@ -11,13 +11,12 @@
#import "ios/web/public/web_client.h"
namespace ios_web_view {
-class WebViewBrowserState;
class WebViewWebMainParts;
// WebView implementation of WebClient.
class WebViewWebClient : public web::WebClient {
public:
- explicit WebViewWebClient(const std::string& user_agent_product);
+ WebViewWebClient();
~WebViewWebClient() override;
// WebClient implementation.
@@ -26,10 +25,8 @@ class WebViewWebClient : public web::WebClient {
std::string GetUserAgent(web::UserAgentType type) const override;
NSString* GetEarlyPageScript(web::BrowserState* browser_state) const override;
- // Normal browser state associated with the receiver.
- WebViewBrowserState* browser_state() const;
- // Off the record browser state associated with the receiver.
- WebViewBrowserState* off_the_record_browser_state() const;
+ // Setter to modify the User Agent product.
+ void SetProduct(const std::string& user_agent_product);
Eugene But (OOO till 7-30) 2017/04/11 17:52:42 Do you want to split ownership refactoring and add
michaeldo 2017/04/11 21:57:03 I tried to do this, but I would have to set user_a
private:
// The name of the product to be used in the User Agent string.

Powered by Google App Engine
This is Rietveld 408576698