Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2791393002: Clean up finalization of recursive types in the VM. (Closed)

Created:
3 years, 8 months ago by regis
Modified:
3 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M runtime/vm/class_finalizer.cc View 2 chunks +18 lines, -10 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
regis
3 years, 8 months ago (2017-04-03 19:52:18 UTC) #2
rmacnak
lgtm
3 years, 8 months ago (2017-04-03 21:25:29 UTC) #3
regis
Thanks!
3 years, 8 months ago (2017-04-03 21:26:44 UTC) #4
regis
3 years, 8 months ago (2017-04-03 21:28:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5065c1c0c4ac5b65fabb7a96c969ec3886e9b8ca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698