third_party/WebKit/LayoutTests/external/wpt/staticrange/staticrange-immutable.html - Issue 2791373002: [InputEvent] Make StaticRange immutable and move tests to wpt

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/staticrange/staticrange-immutable.html

Issue 2791373002: [InputEvent] Make StaticRange immutable and move tests to wpt (Closed)

Patch Set: Make attributes immutable and address foolip's comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/external/wpt/staticrange/idlharness.html ('K') | « third_party/WebKit/LayoutTests/external/wpt/staticrange/idlharness-expected.txt ('k') | third_party/WebKit/LayoutTests/external/wpt/uievents/constructors/inputevent-constructor.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <title>StaticRange: Attributes are immutable</title>

	3 <script src="/resources/testharness.js"></script>

	4 <script src="/resources/testharnessreport.js"></script>

	5 <div id='txt'>

	6 abcdefg

	7 </div>

	8 <script>

	9 test(() => {

	10 const txt = document.getElementById('txt');

	11 const staticRange = new StaticRange();

	12 assert_equals(staticRange.startContainer, document);

	13 assert_equals(staticRange.startOffset, 0);

	14 assert_equals(staticRange.endContainer, document);

	15 assert_equals(staticRange.endOffset, 0);

	16 assert_true(staticRange.collapsed);

	17

	18 staticRange.startContainer = txt;

	19 assert_equals(staticRange.startContainer, document);

	20 staticRange.startOffset = 1;

	21 assert_equals(staticRange.startOffset, 0);

	22 staticRange.endContainer = txt;

	23 assert_equals(staticRange.endContainer, document);

	24 staticRange.endOffset = 1;

	25 assert_equals(staticRange.endOffset, 0);

	26 assert_true(staticRange.collapsed);

	27 });
	qyearsley 2017/04/11 21:18:46 BTW, is it correct that we're not giving this subt BTW, is it correct that we're not giving this subtest a name since there's only one subtest in this test file and it the test already has a title "StaticRange: Attributes are immutable"? chongz 2017/04/11 22:11:30 I was following the guide here: https://chromium.g Show quoted text On 2017/04/11 21:18:46, qyearsley wrote: > BTW, is it correct that we're not giving this subtest a name since there's only > one subtest in this test file and it the test already has a title "StaticRange: > Attributes are immutable"? I was following the guide here: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/writing_... ``` Test files with a single test case should omit the test case description. The file's <title> should be sufficient to describe the scenario being tested. ``` Or do we have other suggestions? Also see: https://groups.google.com/a/chromium.org/d/msg/blink-dev/XsR6PKRrS1E/Guv2rK0b... qyearsley 2017/04/11 22:31:50 No, that sounds good, I was just curious :-) Show quoted text On 2017/04/11 at 22:11:30, chongz wrote: > On 2017/04/11 21:18:46, qyearsley wrote: > > BTW, is it correct that we're not giving this subtest a name since there's only > > one subtest in this test file and it the test already has a title "StaticRange: > > Attributes are immutable"? > > I was following the guide here: > https://chromium.googlesource.com/chromium/src/+/master/docs/testing/writing_... > ``` > Test files with a single test case should omit the test case description. The file's <title> should be sufficient to describe the scenario being tested. > ``` > > Or do we have other suggestions? > No, that sounds good, I was just curious :-) foolip 2017/04/12 04:56:23 FWIW, I like it this way :) Show quoted text On 2017/04/11 22:31:50, qyearsley wrote: > On 2017/04/11 at 22:11:30, chongz wrote: > > On 2017/04/11 21:18:46, qyearsley wrote: > > > BTW, is it correct that we're not giving this subtest a name since there's > only > > > one subtest in this test file and it the test already has a title > "StaticRange: > > > Attributes are immutable"? > > > > I was following the guide here: > > > https://chromium.googlesource.com/chromium/src/+/master/docs/testing/writing_... > > ``` > > Test files with a single test case should omit the test case description. The > file's <title> should be sufficient to describe the scenario being tested. > > ``` > > > > Or do we have other suggestions? > > > > No, that sounds good, I was just curious :-) FWIW, I like it this way :)
	28 </script>

OLD	NEW