third_party/WebKit/LayoutTests/external/wpt/dom/ranges/StaticRange-mutable.html - Issue 2791373002: [InputEvent] Make StaticRange immutable and move tests to wpt

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/dom/ranges/StaticRange-mutable.html

Issue 2791373002: [InputEvent] Make StaticRange immutable and move tests to wpt (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/external/wpt/dom/ranges/StaticRange-constructor.html ('K') | « third_party/WebKit/LayoutTests/external/wpt/dom/ranges/StaticRange-constructor.html ('k') | third_party/WebKit/LayoutTests/external/wpt/dom/ranges/StaticRange-no-mutation.html » ('j') | third_party/WebKit/LayoutTests/external/wpt/dom/ranges/StaticRange-no-mutation.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!doctype html>

	2 <title>StaticRange: Property mutable and .setStart/.setEnd</title>

	3 <script src="/resources/testharness.js"></script>

	4 <script src="/resources/testharnessreport.js"></script>

	5 <div id='txt'>

	6 abcdefg

	7 </div>

	8 <script>

	9 test(() => {

	10 const txt = document.getElementById('txt');

	11 const staticRange = new StaticRange();

	12 staticRange.startContainer = txt;

	13 staticRange.startOffset = 0;

	14 staticRange.endContainer = txt;

	15 staticRange.endOffset = 1;

	16 assert_equals(staticRange.startContainer, txt);

	17 assert_equals(staticRange.startOffset, 0);

	18 assert_equals(staticRange.endContainer, txt);

	19 assert_equals(staticRange.endOffset, 1);

	20 assert_false(staticRange.collapsed);

	21 }, 'Property mutable');
	foolip 2017/04/04 04:32:36 Suggest 'Mutable attributes' or 'Attributes are mu Suggest 'Mutable attributes' or 'Attributes are mutable' chongz 2017/04/07 18:14:11 Changed to test "Attributes are immutable". Show quoted text On 2017/04/04 04:32:36, foolip_UTC7 wrote: > Suggest 'Mutable attributes' or 'Attributes are mutable' Changed to test "Attributes are immutable".
	22

	23 test(() => {

	24 const txt = document.getElementById('txt');

	25 const staticRange = new StaticRange();

	26 staticRange.setStart(txt, 0);

	27 staticRange.setEnd(txt, 1);

	28 assert_equals(staticRange.startContainer, txt);

	29 assert_equals(staticRange.startOffset, 0);

	30 assert_equals(staticRange.endContainer, txt);

	31 assert_equals(staticRange.endOffset, 1);

	32 assert_false(staticRange.collapsed);

	33 }, 'setStart, setEnd');
	foolip 2017/04/04 04:32:36 Can you split this into two separate tests, and as Can you split this into two separate tests, and assert that setStart() has no effect on endContainer/endOffset and vice versa? Also, test what happens when startOffset is set to -1 or a number >= https://dom.spec.whatwg.org/#concept-node-length chongz 2017/04/07 18:14:11 Removed \|setStart/End()\|. Show quoted text On 2017/04/04 04:32:36, foolip_UTC7 wrote: > Can you split this into two separate tests, and assert that setStart() has no > effect on endContainer/endOffset and vice versa? > > Also, test what happens when startOffset is set to -1 or a number >= > https://dom.spec.whatwg.org/#concept-node-length Removed \|setStart/End()\|.
	34 </script>

OLD	NEW