third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp - Issue 2791303002: Clone MediaStream video tracks correctly with spec-compliant constraints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp

Issue 2791303002: Clone MediaStream video tracks correctly with spec-compliant constraints. (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp b/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp

index 351f851366840854264764e663142d5d5d7ba969..e2cc8ba73bf8cfc1418c93983361ecbf8a99ec5c 100644

--- a/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp

@@ -216,7 +216,8 @@ MediaStreamTrack* MediaStreamTrack::clone(ScriptState* scriptState) {

MediaStreamComponent* clonedComponent = component()->clone();

MediaStreamTrack* clonedTrack = MediaStreamTrack::create(

scriptState->getExecutionContext(), clonedComponent);

- MediaStreamCenter::instance().didCreateMediaStreamTrack(clonedComponent);

+ MediaStreamCenter::instance().didCloneMediaStreamTrack(component(),

+ clonedComponent);

return clonedTrack;

}