Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 2791263005: Split MirrorsData methods and MirrorsDataImpl data by element kind. (Closed)
Patch Set: Updated cf. comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/mirrors_analysis.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_backend/backend.dart
diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart
index 20c42fa2506c932e49576acfcda265e272359ee4..6c5d68efcc4c5ab4312f12670eb7ed9ea4820ff0 100644
--- a/pkg/compiler/lib/src/js_backend/backend.dart
+++ b/pkg/compiler/lib/src/js_backend/backend.dart
@@ -315,7 +315,7 @@ class JavaScriptBackend {
/// Set of classes that need to be considered for reflection although not
/// otherwise visible during resolution.
- Iterable<ClassElement> get classesRequiredForReflection {
+ Iterable<ClassEntity> get classesRequiredForReflection {
// TODO(herhut): Clean this up when classes needed for rti are tracked.
return [helpers.closureClass, helpers.jsIndexableClass];
}
@@ -327,8 +327,8 @@ class JavaScriptBackend {
/**
* The generated code as a js AST for compiled methods.
*/
- final Map<Element, jsAst.Expression> generatedCode =
- <Element, jsAst.Expression>{};
+ final Map<MemberElement, jsAst.Expression> generatedCode =
+ <MemberElement, jsAst.Expression>{};
FunctionInlineCache inlineCache = new FunctionInlineCache();
@@ -960,7 +960,7 @@ class JavaScriptBackend {
}
WorldImpact codegen(CodegenWorkItem work) {
- Element element = work.element;
+ MemberElement element = work.element;
if (compiler.elementHasCompileTimeError(element)) {
DiagnosticMessage message =
// If there's more than one error, the first is probably most
@@ -984,8 +984,7 @@ class JavaScriptBackend {
return const CodegenImpact();
}
if (kind.category == ElementCategory.VARIABLE) {
- // ignore: INVALID_ASSIGNMENT
- VariableElement variableElement = element;
+ FieldElement variableElement = element;
ConstantExpression constant = variableElement.constant;
if (constant != null) {
ConstantValue initialValue = constants.getConstantValue(constant);
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/mirrors_analysis.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698