Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6719)

Unified Diff: chrome/browser/signin/signin_error_notifier_ash_unittest.cc

Issue 279123002: Disable SigninErrorNotifierTest.AuthStatusEnumerateAllErrors and SigninErrorNotifierTest.ErrorAuthS… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_error_notifier_ash_unittest.cc
diff --git a/chrome/browser/signin/signin_error_notifier_ash_unittest.cc b/chrome/browser/signin/signin_error_notifier_ash_unittest.cc
index c8e7b5e4536760078c91f97f2686aa01fb3de55d..3d7622b3ce905be59387e9bc7e8435e45464e5fe 100644
--- a/chrome/browser/signin/signin_error_notifier_ash_unittest.cc
+++ b/chrome/browser/signin/signin_error_notifier_ash_unittest.cc
@@ -124,6 +124,8 @@ TEST_F(SigninErrorNotifierTest, NoErrorAuthStatusProviders) {
ASSERT_FALSE(notification_ui_manager_->FindById(kNotificationId));
}
+#if !defined(OS_WIN)
+// Disabled on Win due to flake. http://crbug.com/372236
TEST_F(SigninErrorNotifierTest, ErrorAuthStatusProvider) {
{
FakeAuthStatusProvider provider(error_controller_);
@@ -140,6 +142,7 @@ TEST_F(SigninErrorNotifierTest, ErrorAuthStatusProvider) {
// All providers should be removed now.
ASSERT_FALSE(notification_ui_manager_->FindById(kNotificationId));
}
+#endif
TEST_F(SigninErrorNotifierTest, AuthStatusProviderErrorTransition) {
{
@@ -177,6 +180,8 @@ TEST_F(SigninErrorNotifierTest, AuthStatusProviderErrorTransition) {
}
}
+#if !defined(OS_WIN)
+// Disabled on Win due to flake. http://crbug.com/372236
// Verify that SigninErrorNotifier ignores certain errors.
TEST_F(SigninErrorNotifierTest, AuthStatusEnumerateAllErrors) {
typedef struct {
@@ -216,6 +221,7 @@ TEST_F(SigninErrorNotifierTest, AuthStatusEnumerateAllErrors) {
}
}
}
+#endif
} // namespace test
} // namespace ash
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698