Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: third_party/WebKit/Source/core/page/PageAnimator.h

Issue 2791223002: Notify Blink to suppress frame requests during BeginMainFrame (Closed)
Patch Set: DCHECK update Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/PageAnimator.h
diff --git a/third_party/WebKit/Source/core/page/PageAnimator.h b/third_party/WebKit/Source/core/page/PageAnimator.h
index c2e62ae89d9e3920d98c99caeb788406585ae430..96843efe81734e149a9f4a285943e10887beb300 100644
--- a/third_party/WebKit/Source/core/page/PageAnimator.h
+++ b/third_party/WebKit/Source/core/page/PageAnimator.h
@@ -23,6 +23,12 @@ class CORE_EXPORT PageAnimator final : public GarbageCollected<PageAnimator> {
bool isServicingAnimations() const { return m_servicingAnimations; }
+ // TODO(alancutter): Remove the need for this by implementing frame request
+ // suppression logic at the BeginMainFrame level. This is a temporary
+ // workaround to fix a perf regression.
+ // DO NOT use this outside of crbug.com/704763.
+ void setSuppressFrameRequestsWorkaroundFor704763Only(bool);
+
// See documents of methods with the same names in FrameView class.
void updateAllLifecyclePhases(LocalFrame& rootFrame);
AnimationClock& clock() { return m_animationClock; }
@@ -33,6 +39,7 @@ class CORE_EXPORT PageAnimator final : public GarbageCollected<PageAnimator> {
Member<Page> m_page;
bool m_servicingAnimations;
bool m_updatingLayoutAndStyleForPainting;
+ bool m_suppressFrameRequestsWorkaroundFor704763Only = false;
AnimationClock m_animationClock;
};

Powered by Google App Engine
This is Rietveld 408576698