Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Side by Side Diff: third_party/WebKit/Source/web/WebPagePopupImpl.h

Issue 2791223002: Notify Blink to suppress frame requests during BeginMainFrame (Closed)
Patch Set: DCHECK update Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 WebCompositeAndReadbackAsyncCallback*) override; 69 WebCompositeAndReadbackAsyncCallback*) override;
70 WebPoint positionRelativeToOwner() override; 70 WebPoint positionRelativeToOwner() override;
71 void postMessage(const String& message) override; 71 void postMessage(const String& message) override;
72 void cancel(); 72 void cancel();
73 73
74 // PageWidgetEventHandler functions. 74 // PageWidgetEventHandler functions.
75 WebInputEventResult handleKeyEvent(const WebKeyboardEvent&) override; 75 WebInputEventResult handleKeyEvent(const WebKeyboardEvent&) override;
76 76
77 private: 77 private:
78 // WebWidget functions 78 // WebWidget functions
79 void setSuppressFrameRequestsWorkaroundFor704763Only(bool) final;
79 void beginFrame(double lastFrameTimeMonotonic) override; 80 void beginFrame(double lastFrameTimeMonotonic) override;
80 void updateAllLifecyclePhases() override; 81 void updateAllLifecyclePhases() override;
81 void willCloseLayerTreeView() override; 82 void willCloseLayerTreeView() override;
82 void paint(WebCanvas*, const WebRect&) override; 83 void paint(WebCanvas*, const WebRect&) override;
83 void resize(const WebSize&) override; 84 void resize(const WebSize&) override;
84 void close() override; 85 void close() override;
85 WebInputEventResult handleInputEvent(const WebCoalescedInputEvent&) override; 86 WebInputEventResult handleInputEvent(const WebCoalescedInputEvent&) override;
86 void setFocus(bool) override; 87 void setFocus(bool) override;
87 bool isPagePopup() const override { return true; } 88 bool isPagePopup() const override { return true; }
88 bool isAcceleratedCompositingActive() const override { 89 bool isAcceleratedCompositingActive() const override {
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 WebWidget, 132 WebWidget,
132 widget, 133 widget,
133 widget->isPagePopup(), 134 widget->isPagePopup(),
134 widget.isPagePopup()); 135 widget.isPagePopup());
135 // WebPagePopupImpl is the only implementation of PagePopup, so no 136 // WebPagePopupImpl is the only implementation of PagePopup, so no
136 // further checking required. 137 // further checking required.
137 DEFINE_TYPE_CASTS(WebPagePopupImpl, PagePopup, popup, true, true); 138 DEFINE_TYPE_CASTS(WebPagePopupImpl, PagePopup, popup, true, true);
138 139
139 } // namespace blink 140 } // namespace blink
140 #endif // WebPagePopupImpl_h 141 #endif // WebPagePopupImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698