Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h

Issue 2791193004: [Typed CSSOM] New design for computed styles which includes custom properties (Closed)
Patch Set: tidy up Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
diff --git a/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h b/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
index 7ea52a29167aa6c2502d969b05da187a2061c9f5..723d4f45488c53f037f41b66e26ae64854588d56 100644
--- a/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
+++ b/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
@@ -32,32 +32,30 @@ class CORE_EXPORT ComputedStylePropertyMap : public StylePropertyMapReadonly {
Vector<String> getProperties() override;
DEFINE_INLINE_VIRTUAL_TRACE() {
- visitor->trace(m_computedStyleDeclaration);
visitor->trace(m_node);
StylePropertyMapReadonly::trace(visitor);
}
- private:
- Node* node() const;
-
protected:
ComputedStylePropertyMap(Node* node, const String& pseudoElement = String())
: StylePropertyMapReadonly(),
- m_computedStyleDeclaration(
- CSSComputedStyleDeclaration::create(node, false, pseudoElement)),
m_pseudoId(CSSSelector::parsePseudoId(pseudoElement)),
m_node(node) {}
CSSStyleValueVector getAllInternal(CSSPropertyID) override;
- CSSStyleValueVector getAllInternal(AtomicString customPropertyName) override;
+ CSSStyleValueVector getAllInternal(AtomicString customPropertyName,
+ ExceptionState&) override;
HeapVector<StylePropertyMapEntry> getIterationEntries() override {
return HeapVector<StylePropertyMapEntry>();
}
- Member<CSSComputedStyleDeclaration> m_computedStyleDeclaration;
PseudoId m_pseudoId;
Member<Node> m_node;
+
+ private:
+ Node* styledNode() const;
+ const ComputedStyle* updateStyle() const;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698