[Typed CSSOM] New design for computed styles which includes custom properties

third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h

Index: third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
diff --git a/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h b/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
index 0aa4ca4ef58f299af4c7fd5dc02740b7de8d574e..68f97f0c3dae398a16a1684bd4aba524ea20874a 100644
--- a/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
+++ b/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
@@ -32,19 +32,13 @@ class CORE_EXPORT ComputedStylePropertyMap : public StylePropertyMapReadonly {
   Vector<String> getProperties() override;
 
   DEFINE_INLINE_VIRTUAL_TRACE() {
-    visitor->Trace(computed_style_declaration_);
     visitor->Trace(node_);
     StylePropertyMapReadonly::Trace(visitor);
   }
 
- private:
-  Node* GetNode() const;
-
  protected:
   ComputedStylePropertyMap(Node* node, const String& pseudo_element = String())
       : StylePropertyMapReadonly(),
-        computed_style_declaration_(
-            CSSComputedStyleDeclaration::Create(node, false, pseudo_element)),
         pseudo_id_(CSSSelector::ParsePseudoId(pseudo_element)),
         node_(node) {}
 
@@ -56,9 +50,12 @@ class CORE_EXPORT ComputedStylePropertyMap : public StylePropertyMapReadonly {
     return HeapVector<StylePropertyMapEntry>();
   }
 
-  Member<CSSComputedStyleDeclaration> computed_style_declaration_;
   PseudoId pseudo_id_;
   Member<Node> node_;
+
+ private:
+  Node* StyledNode() const;
+  const ComputedStyle* UpdateStyle() const;

[alancutter (OOO until 2018), 2017/05/11 04:34:04]

Does this method need to be const?

[rjwright, 2017/05/12 04:47:34]

Sasha asked me ages ago to make as much stuff const as possible. I'm not sure
what the best practice is. Eddy, do you know?

[alancutter (OOO until 2018), 2017/05/12 04:53:15]

I think what Sasha meant was to make types as const as possible. Marking methods
as const is a little bit different.

I pointed this one out because it's very strange for a const method to have a
name like "Update", the name implies mutation.

 };
 
 }  // namespace blink