Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h

Issue 2791193004: [Typed CSSOM] New design for computed styles which includes custom properties (Closed)
Patch Set: replace node check with dcheck Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
diff --git a/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h b/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
index 0aa4ca4ef58f299af4c7fd5dc02740b7de8d574e..68f97f0c3dae398a16a1684bd4aba524ea20874a 100644
--- a/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
+++ b/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h
@@ -32,19 +32,13 @@ class CORE_EXPORT ComputedStylePropertyMap : public StylePropertyMapReadonly {
Vector<String> getProperties() override;
DEFINE_INLINE_VIRTUAL_TRACE() {
- visitor->Trace(computed_style_declaration_);
visitor->Trace(node_);
StylePropertyMapReadonly::Trace(visitor);
}
- private:
- Node* GetNode() const;
-
protected:
ComputedStylePropertyMap(Node* node, const String& pseudo_element = String())
: StylePropertyMapReadonly(),
- computed_style_declaration_(
- CSSComputedStyleDeclaration::Create(node, false, pseudo_element)),
pseudo_id_(CSSSelector::ParsePseudoId(pseudo_element)),
node_(node) {}
@@ -56,9 +50,12 @@ class CORE_EXPORT ComputedStylePropertyMap : public StylePropertyMapReadonly {
return HeapVector<StylePropertyMapEntry>();
}
- Member<CSSComputedStyleDeclaration> computed_style_declaration_;
PseudoId pseudo_id_;
Member<Node> node_;
+
+ private:
+ Node* StyledNode() const;
+ const ComputedStyle* UpdateStyle() const;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698