[Typed CSSOM] New design for computed styles which includes custom properties

third_party/WebKit/Source/core/css/cssom/StylePropertyMapReadonly.cpp

 // Copyright 2016 the chromium authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/cssom/StylePropertyMapReadonly.h"
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "core/css/CSSValueList.h"
 #include "core/css/cssom/CSSSimpleLength.h"
 #include "core/css/cssom/CSSStyleValue.h"
@@ skipping 33 matching lines @@
 
  private:
   size_t m_index;
   const HeapVector<StylePropertyMapReadonly::StylePropertyMapEntry> m_values;
 };
 
 }  // namespace
 
 CSSStyleValue* StylePropertyMapReadonly::get(const String& propertyName,
                                              ExceptionState& exceptionState) {
-  CSSPropertyID propertyID = cssPropertyID(propertyName);
-  if (propertyID == CSSPropertyInvalid || propertyID == CSSPropertyVariable) {
-    // TODO(meade): Handle custom properties here.
-    exceptionState.throwTypeError("Invalid propertyName: " + propertyName);
-    return nullptr;
-  }
-
-  CSSStyleValueVector styleVector = getAllInternal(propertyID);
-  if (styleVector.isEmpty())
-    return nullptr;
-
-  return styleVector[0];
+  CSSStyleValueVector styleVector = getAll(propertyName, exceptionState);
+  return styleVector.isEmpty() ? nullptr : styleVector[0];
 }
 
 CSSStyleValueVector StylePropertyMapReadonly::getAll(
     const String& propertyName,
     ExceptionState& exceptionState) {
   CSSPropertyID propertyID = cssPropertyID(propertyName);
-  if (propertyID != CSSPropertyInvalid && propertyID != CSSPropertyVariable)
-    return getAllInternal(propertyID);
-
-  // TODO(meade): Handle custom properties here.
-  exceptionState.throwTypeError("Invalid propertyName: " + propertyName);
-  return CSSStyleValueVector();
+  if (propertyID == CSSPropertyInvalid) {
+    exceptionState.throwTypeError("Invalid propertyName: " + propertyName);
+    return CSSStyleValueVector();
+  }
+  if (propertyID == CSSPropertyVariable)
+    return getAllInternal(AtomicString(propertyName), exceptionState);
+  return getAllInternal(propertyID);
 }
 
 bool StylePropertyMapReadonly::has(const String& propertyName,
                                    ExceptionState& exceptionState) {
-  CSSPropertyID propertyID = cssPropertyID(propertyName);
-  if (propertyID != CSSPropertyInvalid && propertyID != CSSPropertyVariable)
-    return !getAllInternal(propertyID).isEmpty();
-
-  // TODO(meade): Handle custom properties here.
-  exceptionState.throwTypeError("Invalid propertyName: " + propertyName);
-  return false;
+  return !getAll(propertyName, exceptionState).isEmpty();
 }
 
 StylePropertyMapReadonly::IterationSource*
 StylePropertyMapReadonly::startIteration(ScriptState*, ExceptionState&) {
   return new StylePropertyMapIterationSource(getIterationEntries());
 }
 
 }  // namespace blink