Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: base/metrics/histogram_functions.h

Issue 2791193002: Log metrics for the Location Settings Dialog prompt for geolocation. (Closed)
Patch Set: Feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/metrics/histogram_functions.h
diff --git a/base/metrics/histogram_functions.h b/base/metrics/histogram_functions.h
index 58fc30173c6ea17480175440202c384b96661261..851171e4a5db3a6709e6261c3f1d5727d20ae4a1 100644
--- a/base/metrics/histogram_functions.h
+++ b/base/metrics/histogram_functions.h
@@ -43,7 +43,8 @@ template <typename T>
void UmaHistogramEnumeration(const std::string& name, T sample, T max) {
static_assert(std::is_enum<T>::value,
"Non enum passed to UmaHistogramEnumeration");
- return UmaHistogramExactLinear(name, static_cast<int>(sample), max);
+ return UmaHistogramExactLinear(name, static_cast<int>(sample),
+ static_cast<int>(max));
Ilya Sherman 2017/04/04 16:37:55 I'd prefer that you make this change in a separate
}
// For adding boolean sample to histogram.

Powered by Google App Engine
This is Rietveld 408576698