tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 31774c7ed82606dfcfe74fdb4a4a19feb94b0f78..be3c85cd1bc29ae136cada9bb064b05e978bbcc1 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -21371,6 +21371,42 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   </summary>
 </histogram>
 
+<histogram name="GeolocationSettingsDialog.AcceptEvent"

[Ilya Sherman, 2017/04/04 00:04:41]

nit: Please add base="true" here and for the other histograms, since these names
are just partial histogram names, used to construct full names via
histogram_suffixes.

[Ilya Sherman, 2017/04/04 05:11:07]

Sorry, just noticing this: Could you please name these histograms
"Geolocation.SettingsDialog.*", so that they fit into the existing "Geolocation"
category?  Everything before the first dot in the histogram name essentially
falls into a global namespace, so we want to limit top-level entries in that
namespace to a reasonably small set.

[benwells, 2017/04/04 08:06:39]

Done.

[benwells, 2017/04/04 08:06:39]

Done.

+    enum="GeolocationSettingsDialogBackOff">
+  <owner>benwells@chromium.org</owner>
+  <summary>
+    Records the backoff level when the Location Settings Dialog is accepted by
+    the user.
+  </summary>
+</histogram>
+
+<histogram name="GeolocationSettingsDialog.DenyEvent"
+    enum="GeolocationSettingsDialogBackOff">
+  <owner>benwells@chromium.org</owner>
+  <summary>
+    Records the backoff level when the Location Settings Dialog is rejected by
+    the user.
+  </summary>
+</histogram>
+
+<histogram name="GeolocationSettingsDialog.ShowEvent"
+    enum="GeolocationSettingsDialogBackOff">
+  <owner>benwells@chromium.org</owner>
+  <summary>
+    Records the backoff level when the Location Settings Dialog is shown to the
+    user.
+  </summary>
+</histogram>
+
+<histogram name="GeolocationSettingsDialog.SuppressEvent"
+    enum="GeolocationSettingsDialogBackOff">
+  <owner>benwells@chromium.org</owner>
+  <summary>
+    Records the backoff level when the Location Settings Dialog is suppressed
+    due to backoff.
+  </summary>
+</histogram>
+
 <histogram name="GoogleNow.Card.Button.Clicked0" enum="GoogleNowCardTypeId">
   <owner>robliao@chromium.org</owner>
   <owner>skare@chromium.org</owner>
@@ -96680,6 +96716,12 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
   <int value="5" label="User ignored the bar"/>
 </enum>
 
+<enum name="GeolocationSettingsDialogBackOff" type="int">
+  <int value="0" label="One week"/>
+  <int value="1" label="One month"/>
+  <int value="2" label="Three months"/>
+</enum>
+
 <enum name="GeopositionErrorCode" type="int">
   <int value="0" label="There was no error"/>
   <int value="1" label="User denied use of geolocation"/>
@@ -118121,6 +118163,15 @@ from previous Chrome versions.
   <affected-histogram name="PLT.PT_StartToFinish"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="GeolocationSettingsDialogSource">
+  <suffix name="DSE" label="Default search engine"/>
+  <suffix name="NonDSE" label="Non-default search engine"/>
+  <affected-histogram name="GeolocationSettingsDialog.AcceptEvent"/>
+  <affected-histogram name="GeolocationSettingsDialog.DenyEvent"/>
+  <affected-histogram name="GeolocationSettingsDialog.ShowEvent"/>
+  <affected-histogram name="GeolocationSettingsDialog.SuppressEvent"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="GLApisWithErrorReporting">
   <suffix name="TexImage2D" label="All GL APIs that allocate a 2D texture."/>
   <suffix name="TexImage3D" label="All GL APIs that allocate a 3D texture."/>