[Sync] Restore previous session if no tabbed windows present

components/sync_sessions/sessions_sync_manager.h

Index: components/sync_sessions/sessions_sync_manager.h
diff --git a/components/sync_sessions/sessions_sync_manager.h b/components/sync_sessions/sessions_sync_manager.h
index bf72e9e716e296e8eb9c31f62402f28ea756e766..f37995bfaaeabddc5e60021a1e0fcdaab832cc7c 100644
--- a/components/sync_sessions/sessions_sync_manager.h
+++ b/components/sync_sessions/sessions_sync_manager.h
@@ -119,7 +119,7 @@ class SessionsSyncManager : public syncer::SyncableService,
  private:
   friend class extensions::ExtensionSessionsTest;
   friend class SessionsSyncManagerTest;
-  FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest, PopulateSessionHeader);
+  FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest, PopulateSyncedSession);
   FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest, PopulateSessionWindow);
   FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest, ValidTabs);
   FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest, SetSessionTabFromDelegate);
@@ -187,14 +187,15 @@ class SessionsSyncManager : public syncer::SyncableService,
 
   // Used to populate a session header from the session specifics header
   // provided.
-  static void PopulateSessionHeaderFromSpecifics(
+  void PopulateSyncedSessionFromSpecifics(
+      const std::string& session_tag,
       const sync_pb::SessionHeader& header_specifics,
       base::Time mtime,
-      SyncedSession* session_header);
+      SyncedSession* synced_session);
 
-  // Builds |session_window| from the session specifics window
+  // Builds |synced_session_window| from the session specifics window
   // provided and updates the SessionTracker with foreign session data created.
-  void BuildSyncedSessionFromSpecifics(
+  void PopulateSyncedSessionWindowFromSpecifics(
       const std::string& session_tag,
       const sync_pb::SessionWindow& specifics,
       base::Time mtime,
@@ -246,6 +247,11 @@ class SessionsSyncManager : public syncer::SyncableService,
       SessionID::id_type new_window_id,
       syncer::SyncChangeList* change_output);
 
+  // Updates a sync tab node based on local tab information.

[skym, 2017/04/17 20:37:02]

I don't like the term update being used here. Yes, you're using an
ACTION_UPDATE, but this is really preparing the sync change to be given to sync
for an existing tab. What do you think of AppendChangeForExistingTab().

[Nicolas Zea, 2017/04/17 21:24:54]

Done.

+  void UpdateTabSpecifics(int sync_id,
+                          const sessions::SessionTab& tab,
+                          syncer::SyncChangeList* change_output);
+
   // Stops and re-starts syncing to rebuild association mappings. Returns true
   // when re-starting succeeds.
   // See |local_tab_pool_out_of_sync_|.