Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: components/sync_sessions/sessions_sync_manager.h

Issue 2791183003: [Sync] Restore previous session if no tabbed windows present (Closed)
Patch Set: Fix ios compile Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_sessions/sessions_sync_manager.h
diff --git a/components/sync_sessions/sessions_sync_manager.h b/components/sync_sessions/sessions_sync_manager.h
index bf72e9e716e296e8eb9c31f62402f28ea756e766..80706d86d7436d04765c9d3b696cce958e616a12 100644
--- a/components/sync_sessions/sessions_sync_manager.h
+++ b/components/sync_sessions/sessions_sync_manager.h
@@ -119,7 +119,7 @@ class SessionsSyncManager : public syncer::SyncableService,
private:
friend class extensions::ExtensionSessionsTest;
friend class SessionsSyncManagerTest;
- FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest, PopulateSessionHeader);
+ FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest, PopulateSyncedSession);
FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest, PopulateSessionWindow);
FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest, ValidTabs);
FRIEND_TEST_ALL_PREFIXES(SessionsSyncManagerTest, SetSessionTabFromDelegate);
@@ -187,14 +187,15 @@ class SessionsSyncManager : public syncer::SyncableService,
// Used to populate a session header from the session specifics header
// provided.
- static void PopulateSessionHeaderFromSpecifics(
+ void PopulateSyncedSessionFromSpecifics(
+ const std::string& session_tag,
const sync_pb::SessionHeader& header_specifics,
base::Time mtime,
- SyncedSession* session_header);
+ SyncedSession* synced_session);
- // Builds |session_window| from the session specifics window
+ // Builds |synced_session_window| from the session specifics window
// provided and updates the SessionTracker with foreign session data created.
- void BuildSyncedSessionFromSpecifics(
+ void PopulateSyncedSessionWindowFromSpecifics(
const std::string& session_tag,
const sync_pb::SessionWindow& specifics,
base::Time mtime,
@@ -246,6 +247,12 @@ class SessionsSyncManager : public syncer::SyncableService,
SessionID::id_type new_window_id,
syncer::SyncChangeList* change_output);
+ // Appends an ACTION_UPDATE for a sync tab entity onto |change_output| to
+ // reflect the contents of |tab|, given the tab node id |sync_id|.
+ void AppendChangeForExistingTab(int sync_id,
+ const sessions::SessionTab& tab,
+ syncer::SyncChangeList* change_output);
+
// Stops and re-starts syncing to rebuild association mappings. Returns true
// when re-starting succeeds.
// See |local_tab_pool_out_of_sync_|.

Powered by Google App Engine
This is Rietveld 408576698