Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2791163004: Reverting until bots clear up. (Closed)

Created:
3 years, 8 months ago by bkonyi
Modified:
3 years, 8 months ago
Reviewers:
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reverting until bots clear up. Revert "Pulled a significant portion of Socket implementation into BaseSocket in order to prepare for the synchronous socket impementations which will also use these common methods." This reverts commit 04229201426063e98a752f379b400f922761ed1b. Revert "Updated incorrect call to Write in process_win.cc" This reverts commit 9e1435148b7573896e2fc6a24aab824adb6692cf. Revert "Fixed incorrect call to Write from process_win.cc" This reverts commit 11dcab2bed3c9ec8ec76bc200206ac202a4a5681. Fixed incorrect call to Write from process_win.cc BUG= Committed: https://github.com/dart-lang/sdk/commit/0386f7ab6f51884deb610d50ef25f3ef90c7da53

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2302 lines, -2727 lines) Patch
M runtime/bin/file_system_watcher_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/io_impl_sources.gypi View 1 chunk +5 lines, -13 lines 0 comments Download
M runtime/bin/io_natives.cc View 1 chunk +10 lines, -10 lines 0 comments Download
M runtime/bin/process_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/socket.h View 4 chunks +289 lines, -4 lines 0 comments Download
M runtime/bin/socket.cc View 26 chunks +59 lines, -28 lines 0 comments Download
A + runtime/bin/socket_android.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/bin/socket_android.cc View 6 chunks +364 lines, -3 lines 0 comments Download
D runtime/bin/socket_base.h View 1 chunk +0 lines, -328 lines 0 comments Download
D runtime/bin/socket_base.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D runtime/bin/socket_base_android.h View 1 chunk +0 lines, -16 lines 0 comments Download
D runtime/bin/socket_base_android.cc View 1 chunk +0 lines, -400 lines 0 comments Download
D runtime/bin/socket_base_fuchsia.h View 1 chunk +0 lines, -16 lines 0 comments Download
D runtime/bin/socket_base_fuchsia.cc View 1 chunk +0 lines, -370 lines 0 comments Download
D runtime/bin/socket_base_linux.h View 1 chunk +0 lines, -16 lines 0 comments Download
D runtime/bin/socket_base_linux.cc View 1 chunk +0 lines, -443 lines 0 comments Download
D runtime/bin/socket_base_macos.h View 1 chunk +0 lines, -16 lines 0 comments Download
D runtime/bin/socket_base_macos.cc View 1 chunk +0 lines, -458 lines 0 comments Download
D runtime/bin/socket_base_unsupported.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D runtime/bin/socket_base_win.h View 1 chunk +0 lines, -17 lines 0 comments Download
D runtime/bin/socket_base_win.cc View 1 chunk +0 lines, -444 lines 0 comments Download
A + runtime/bin/socket_fuchsia.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/bin/socket_fuchsia.cc View 6 chunks +306 lines, -5 lines 0 comments Download
A + runtime/bin/socket_linux.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/bin/socket_linux.cc View 7 chunks +406 lines, -5 lines 0 comments Download
A + runtime/bin/socket_macos.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/bin/socket_macos.cc View 6 chunks +420 lines, -3 lines 0 comments Download
M runtime/bin/socket_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/socket_unsupported.cc View 2 chunks +17 lines, -0 lines 0 comments Download
A + runtime/bin/socket_win.h View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/bin/socket_win.cc View 8 chunks +398 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bkonyi
3 years, 8 months ago (2017-04-04 00:25:56 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0386f7ab6f51884deb610d50ef25f3ef90c7da53 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698