Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: components/offline_pages/core/background/request_coordinator.h

Issue 2791013002: Remove outdated TODOs for romax. (Closed)
Patch Set: comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/request_coordinator.h
diff --git a/components/offline_pages/core/background/request_coordinator.h b/components/offline_pages/core/background/request_coordinator.h
index 6103f0b870fb00abb73f40bd5838875412f4392a..412808c9da65364d2abd18b8930919c655623322 100644
--- a/components/offline_pages/core/background/request_coordinator.h
+++ b/components/offline_pages/core/background/request_coordinator.h
@@ -466,7 +466,7 @@ class RequestCoordinator : public KeyedService,
// 2. When a task is not available to be picked by PickRequestTask (because
// it was completed or cancelled), the task will remove it.
// Currently it's used as LIFO.
- // TODO(romax): see if LIFO is a good idea, or change to FIFO.
+ // TODO(romax): see if LIFO is a good idea or change to FIFO. crbug.com/705106
std::deque<int64_t> prioritized_requests_;
// Allows us to pass a weak pointer to callbacks.
base::WeakPtrFactory<RequestCoordinator> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698