Chromium Code Reviews| Index: components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc |
| diff --git a/components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc b/components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc |
| index 56edf8e0303d41e0e7c68b491ad833f5ff782e49..7dcb7898685c94d3c1c31f65c1637a34aeb43a64 100644 |
| --- a/components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc |
| +++ b/components/offline_pages/core/offline_page_metadata_store_impl_unittest.cc |
| @@ -39,7 +39,6 @@ int64_t kFileSize = 234567LL; |
| int64_t kOfflineId = 12345LL; |
| // Build a store with outdated schema to simulate the upgrading process. |
| -// TODO(romax): move it to sql_unittests. |
|
fgorski
2017/04/05 16:50:24
please open a bug to properly rename this file.
romax
2017/04/05 18:41:00
Done. 708700
I was thinking about this, and this f
|
| void BuildTestStoreWithSchemaFromM52(const base::FilePath& file) { |
| sql::Connection connection; |
| ASSERT_TRUE( |
| @@ -634,7 +633,6 @@ TEST_F(OfflinePageMetadataStoreTest, GetOfflinePagesFromInvalidStore) { |
| // Loads a store which has an outdated schema. |
| // This test case would crash if it's not handling correctly when we're loading |
| // old version stores. |
| -// TODO(romax): Move this to sql_unittest. |
| TEST_F(OfflinePageMetadataStoreTest, LoadVersion52Store) { |
| std::unique_ptr<OfflinePageMetadataStore> store( |
| BuildStoreWithSchemaFromM52()); |
| @@ -646,7 +644,6 @@ TEST_F(OfflinePageMetadataStoreTest, LoadVersion52Store) { |
| // Loads a store which has an outdated schema. |
| // This test case would crash if it's not handling correctly when we're loading |
| // old version stores. |
| -// TODO(romax): Move this to sql_unittest. |
| TEST_F(OfflinePageMetadataStoreTest, LoadVersion53Store) { |
| std::unique_ptr<OfflinePageMetadataStore> store( |
| BuildStoreWithSchemaFromM53()); |
| @@ -658,7 +655,6 @@ TEST_F(OfflinePageMetadataStoreTest, LoadVersion53Store) { |
| // Loads a string with schema from M54. |
| // This test case would crash if it's not handling correctly when we're loading |
| // old version stores. |
| -// TODO(romax): Move this to sql_unittest. |
| TEST_F(OfflinePageMetadataStoreTest, LoadVersion54Store) { |
| std::unique_ptr<OfflinePageMetadataStore> store( |
| BuildStoreWithSchemaFromM54()); |
| @@ -670,7 +666,6 @@ TEST_F(OfflinePageMetadataStoreTest, LoadVersion54Store) { |
| // Loads a string with schema from M55. |
| // This test case would crash if it's not handling correctly when we're loading |
| // old version stores. |
| -// TODO(romax): Move this to sql_unittest. |
| TEST_F(OfflinePageMetadataStoreTest, LoadVersion55Store) { |
| std::unique_ptr<OfflinePageMetadataStore> store( |
| BuildStoreWithSchemaFromM55()); |
| @@ -682,7 +677,6 @@ TEST_F(OfflinePageMetadataStoreTest, LoadVersion55Store) { |
| // Loads a string with schema from M56. |
| // This test case would crash if it's not handling correctly when we're loading |
| // old version stores. |
| -// TODO(romax): Move this to sql_unittest. |
| TEST_F(OfflinePageMetadataStoreTest, LoadVersion56Store) { |
| std::unique_ptr<OfflinePageMetadataStore> store( |
| BuildStoreWithSchemaFromM56()); |