chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java - Issue 2791013002: Remove outdated TODOs for romax.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

Issue 2791013002: Remove outdated TODOs for romax. (Closed)

Patch Set: comment by chili Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/background_loader_offliner.cc » ('j') | chrome/browser/android/offline_pages/background_loader_offliner.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

index ec9b4fb1990df5f495ee5d7c53a36dda9abf980b..287ecd601aca41a7c703e129cb29a31c8051324b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageDownloadBridge.java

@@ -141,9 +141,7 @@ public class OfflinePageDownloadBridge implements DownloadServiceDelegate, Offli

// If the resumption was an user action then we have to resume the specific download item.

// Otherwise it can only be called when Chrome starts and we would like to resume all

// pending requests.

- // TODO(romax): it's based on the assumption that if this method is called with

- // |hasUserGesture| == false then we're trying to resume all pending requests. This

- // assumption may change.

+ // We assume that |hasUserGesture| == false means resume all pending requests.

if (hasUserGesture) {

resumeDownload(item.getId());

} else {