content/renderer/media_capture_from_element/canvas_capture_handler.cc - Issue 2790823002: Spec compliant video constraints for getUserMedia behind flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media_capture_from_element/canvas_capture_handler.cc

Issue 2790823002: Spec compliant video constraints for getUserMedia behind flag. (Closed)

Patch Set: rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc ('k') | content/renderer/media_recorder/video_track_recorder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media_capture_from_element/canvas_capture_handler.cc

diff --git a/content/renderer/media_capture_from_element/canvas_capture_handler.cc b/content/renderer/media_capture_from_element/canvas_capture_handler.cc

index a7e852038fbf76945d36ddd182727f5784558331..7ed0725f0e88d8a9294b378cd2bf4da5ea77553c 100644

--- a/content/renderer/media_capture_from_element/canvas_capture_handler.cc

+++ b/content/renderer/media_capture_from_element/canvas_capture_handler.cc

@@ -172,8 +172,6 @@ void CanvasCaptureHandler::StartVideoCapture(

<< media::VideoCaptureFormat::ToString(params.requested_format);

DCHECK(main_render_thread_checker_.CalledOnValidThread());

DCHECK(params.requested_format.IsValid());

- // TODO(emircan): Accomodate to the given frame rate constraints here.

capture_format_ = params.requested_format;

delegate_.reset(new CanvasCaptureHandlerDelegate(new_frame_callback));

DCHECK(delegate_);

@@ -267,10 +265,8 @@ void CanvasCaptureHandler::AddVideoCapturerSourceToVideoTrack(

webkit_source.setExtraData(media_stream_source.get());

web_track->initialize(webkit_source);

- blink::WebMediaConstraints constraints;

- constraints.initialize();

web_track->setTrackData(new MediaStreamVideoTrack(

- media_stream_source.release(), constraints,

+ media_stream_source.release(),

MediaStreamVideoSource::ConstraintsCallback(), true));

}