Spec compliant video constraints for getUserMedia behind flag.

content/renderer/pepper/pepper_media_stream_video_track_host.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/pepper_media_stream_video_track_host.h"
 
 #include <stddef.h>
 
 #include "base/base64.h"
 #include "base/logging.h"
@@ skipping 425 matching lines @@
           new FrameDeliverer(io_task_runner(), frame_callback);
     }
   }
 
   void StopSourceImpl() final {
     if (host_)
       host_->frame_deliverer_ = nullptr;
   }
 
  private:
+  base::Optional<media::VideoCaptureFormat> GetCurrentFormatImpl()
+      const override {
+    DCHECK(!IsOldVideoConstraints());
+    if (host_) {
+      return media::VideoCaptureFormat(
+          host_->plugin_frame_size_, kDefaultOutputFrameRate,
+          ToPixelFormat(host_->plugin_frame_format_));
+    }
+    return base::Optional<media::VideoCaptureFormat>();
+  }

[hbos_chromium, 2017/04/05 12:37:28]

Is this used?

[Guido Urdaneta, 2017/04/05 16:17:17]

Yes. This is an override of a virtual method.
This value is stored in a variable in the original code, but the new code uses
the virtual method.

+
   const base::WeakPtr<PepperMediaStreamVideoTrackHost> host_;
 
   DISALLOW_COPY_AND_ASSIGN(VideoSource);
 };
 
 void PepperMediaStreamVideoTrackHost::DidConnectPendingHostToResource() {
   if (!MediaStreamVideoSink::connected_track().isNull())
     return;
   MediaStreamVideoSink::ConnectToTrack(
       track_, media::BindToCurrentLoop(
@@ skipping 59 matching lines @@
   blink::WebMediaStreamSource webkit_source;
   webkit_source.initialize(blink::WebString::fromASCII(source_id),
                            blink::WebMediaStreamSource::TypeVideo,
                            blink::WebString::fromASCII(kPepperVideoSourceName),
                            false /* remote */);
   MediaStreamVideoSource* const source =
       new VideoSource(weak_factory_.GetWeakPtr());
   webkit_source.setExtraData(source);  // Takes ownership of |source|.
 
   const bool enabled = true;
-  blink::WebMediaConstraints constraints;
-  constraints.initialize();
   track_ = MediaStreamVideoTrack::CreateVideoTrack(
-       source, constraints,
-       base::Bind(
-           &PepperMediaStreamVideoTrackHost::OnTrackStarted,
-           base::Unretained(this)),
-       enabled);
+      source,
+      base::Bind(&PepperMediaStreamVideoTrackHost::OnTrackStarted,
+                 base::Unretained(this)),
+      enabled);
   // Note: The call to CreateVideoTrack() returned a track that holds a
   // ref-counted reference to |webkit_source| (and, implicitly, |source|).
 }
 
 void PepperMediaStreamVideoTrackHost::OnTrackStarted(
     MediaStreamSource* source,
     MediaStreamRequestResult result,
     const blink::WebString& result_name) {
   DVLOG(3) << "OnTrackStarted result: " << result;
 }
 
 }  // namespace content