Spec compliant video constraints for getUserMedia behind flag.

content/renderer/media/media_stream_constraints_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_constraints_util.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/renderer/media/media_stream_constraints_util_sets.h"
 #include "third_party/WebKit/public/platform/WebMediaConstraints.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 
 namespace content {
 
 namespace {
 
 template <typename P, typename T>
 bool ScanConstraintsForExactValue(const blink::WebMediaConstraints& constraints,
                                   P picker,
                                   T* value) {
-  DCHECK(!constraints.isNull());
+  if (constraints.isNull())
+    return false;
+
   const auto& the_field = constraints.basic().*picker;
   if (the_field.hasExact()) {
     *value = the_field.exact();
     return true;
   }
   for (const auto& advanced_constraint : constraints.advanced()) {
     const auto& the_field = advanced_constraint.*picker;
     if (the_field.hasExact()) {
       *value = the_field.exact();
       return true;
     }
   }
   return false;
 }
 
 template <typename P, typename T>
 bool ScanConstraintsForMaxValue(const blink::WebMediaConstraints& constraints,
                                 P picker,
                                 T* value) {
-  DCHECK(!constraints.isNull());
+  if (constraints.isNull())
+    return false;
+
   const auto& the_field = constraints.basic().*picker;
   if (the_field.hasMax()) {
     *value = the_field.max();
     return true;
   }
   if (the_field.hasExact()) {
     *value = the_field.exact();
     return true;
   }
   for (const auto& advanced_constraint : constraints.advanced()) {
     const auto& the_field = advanced_constraint.*picker;
     if (the_field.hasMax()) {
       *value = the_field.max();
       return true;
     }
     if (the_field.hasExact()) {
       *value = the_field.exact();
       return true;
     }
   }
   return false;
 }
 
 template <typename P, typename T>
 bool ScanConstraintsForMinValue(const blink::WebMediaConstraints& constraints,
                                 P picker,
                                 T* value) {
-  DCHECK(!constraints.isNull());
+  if (constraints.isNull())
+    return false;
+
   const auto& the_field = constraints.basic().*picker;
   if (the_field.hasMin()) {
     *value = the_field.min();
     return true;
   }
   if (the_field.hasExact()) {
     *value = the_field.exact();
     return true;
   }
   for (const auto& advanced_constraint : constraints.advanced()) {
@@ skipping 147 matching lines @@
   // adjustment.
   if (track_max_frame_rate >= source_format.frame_rate)
     track_max_frame_rate = 0.0;
 
   return VideoTrackAdapterSettings(
       track_max_width, track_max_height, track_min_aspect_ratio,
       track_max_aspect_ratio, track_max_frame_rate);
 }
 
 }  // namespace content