Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 2790773002: Cleanup MenuRunner API (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/scrollbar/base_scroll_bar.cc ('k') | ui/views/examples/menu_example.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/textfield.cc
diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc
index c94481c40db62554dc0905c83ce5946094cc7b3a..99df371c04eab5caea2fe8303af99a1ee0393af8 100644
--- a/ui/views/controls/textfield/textfield.cc
+++ b/ui/views/controls/textfield/textfield.cc
@@ -1051,11 +1051,9 @@ void Textfield::ShowContextMenuForView(View* source,
const gfx::Point& point,
ui::MenuSourceType source_type) {
UpdateContextMenu();
- ignore_result(context_menu_runner_->RunMenuAt(GetWidget(),
- NULL,
- gfx::Rect(point, gfx::Size()),
- MENU_ANCHOR_TOPLEFT,
- source_type));
+ context_menu_runner_->RunMenuAt(GetWidget(), NULL,
+ gfx::Rect(point, gfx::Size()),
+ MENU_ANCHOR_TOPLEFT, source_type);
}
////////////////////////////////////////////////////////////////////////////////
@@ -2038,10 +2036,9 @@ void Textfield::UpdateContextMenu() {
if (controller_)
controller_->UpdateContextMenu(context_menu_contents_.get());
}
- context_menu_runner_.reset(new MenuRunner(context_menu_contents_.get(),
- MenuRunner::HAS_MNEMONICS |
- MenuRunner::CONTEXT_MENU |
- MenuRunner::ASYNC));
+ context_menu_runner_.reset(
+ new MenuRunner(context_menu_contents_.get(),
+ MenuRunner::HAS_MNEMONICS | MenuRunner::CONTEXT_MENU));
}
bool Textfield::ImeEditingAllowed() const {
« no previous file with comments | « ui/views/controls/scrollbar/base_scroll_bar.cc ('k') | ui/views/examples/menu_example.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698