Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: ui/views/controls/menu/menu_runner_impl.h

Issue 2790773002: Cleanup MenuRunner API (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/menu/menu_runner_handler.h ('k') | ui/views/controls/menu/menu_runner_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_runner_impl.h
diff --git a/ui/views/controls/menu/menu_runner_impl.h b/ui/views/controls/menu/menu_runner_impl.h
index 5f4872ca84d72ecba2bb905d141addf2d3b5736f..78fcff7d4823b4ccff58d4820dc03b5d95b00c3a 100644
--- a/ui/views/controls/menu/menu_runner_impl.h
+++ b/ui/views/controls/menu/menu_runner_impl.h
@@ -40,11 +40,11 @@ class VIEWS_EXPORT MenuRunnerImpl
bool IsRunning() const override;
void Release() override;
- MenuRunner::RunResult RunMenuAt(Widget* parent,
- MenuButton* button,
- const gfx::Rect& bounds,
- MenuAnchorPosition anchor,
- int32_t run_types) override;
+ void RunMenuAt(Widget* parent,
+ MenuButton* button,
+ const gfx::Rect& bounds,
+ MenuAnchorPosition anchor,
+ int32_t run_types) override;
void Cancel() override;
base::TimeTicks GetClosingEventTime() const override;
@@ -59,12 +59,6 @@ class VIEWS_EXPORT MenuRunnerImpl
~MenuRunnerImpl() override;
- // Cleans up after the menu is no longer showing. |result| is the menu that
- // the user selected, or NULL if nothing was selected.
- MenuRunner::RunResult MenuDone(NotifyType type,
- MenuItemView* result,
- int mouse_event_flags);
-
// Returns true if mnemonics should be shown in the menu.
bool ShouldShowMnemonics(MenuButton* button);
« no previous file with comments | « ui/views/controls/menu/menu_runner_handler.h ('k') | ui/views/controls/menu/menu_runner_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698