Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: ui/views/controls/combobox/combobox.cc

Issue 2790773002: Cleanup MenuRunner API (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/views/message_view_context_menu_controller.cc ('k') | ui/views/controls/label.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/combobox/combobox.cc
diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc
index 24c51702b2d11798c62274c4add4f29ea5629a8b..a97898cd1a138d63db9f8748f681ed1ac92ae8cb 100644
--- a/ui/views/controls/combobox/combobox.cc
+++ b/ui/views/controls/combobox/combobox.cc
@@ -957,10 +957,10 @@ void Combobox::ShowDropDownMenu(ui::MenuSourceType source_type) {
// Allow |menu_runner_| to be set by the testing API, but if this method is
// ever invoked recursively, ensure the old menu is closed.
if (!menu_runner_ || menu_runner_->IsRunning()) {
- menu_runner_.reset(new MenuRunner(
- menu_model_.get(), MenuRunner::COMBOBOX | MenuRunner::ASYNC,
- base::Bind(&Combobox::OnMenuClosed, base::Unretained(this),
- original_state)));
+ menu_runner_.reset(
+ new MenuRunner(menu_model_.get(), MenuRunner::COMBOBOX,
+ base::Bind(&Combobox::OnMenuClosed,
+ base::Unretained(this), original_state)));
}
menu_runner_->RunMenuAt(GetWidget(), nullptr, bounds, anchor_position,
source_type);
« no previous file with comments | « ui/message_center/views/message_view_context_menu_controller.cc ('k') | ui/views/controls/label.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698