Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7387)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Issue 2790773002: Cleanup MenuRunner API (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/toolbar/app_menu.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_button.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/toolbar_action_view.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
index c447979c1216c3d4110dae9f15c0ac96090dacfa..710d41fc381e0d2dd45e1e7819f837d7dbae92b7 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
@@ -274,8 +274,8 @@ void ToolbarActionView::DoShowContextMenu(
gfx::Point screen_loc;
ConvertPointToScreen(this, &screen_loc);
- int run_types = views::MenuRunner::HAS_MNEMONICS |
- views::MenuRunner::CONTEXT_MENU | views::MenuRunner::ASYNC;
+ int run_types =
+ views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::CONTEXT_MENU;
if (delegate_->ShownInsideMenu())
run_types |= views::MenuRunner::IS_NESTED;
@@ -294,9 +294,8 @@ void ToolbarActionView::DoShowContextMenu(
menu_ = menu_adapter_->CreateMenu();
menu_runner_.reset(new views::MenuRunner(menu_, run_types));
- ignore_result(
- menu_runner_->RunMenuAt(parent, this, gfx::Rect(screen_loc, size()),
- views::MENU_ANCHOR_TOPLEFT, source_type));
+ menu_runner_->RunMenuAt(parent, this, gfx::Rect(screen_loc, size()),
+ views::MENU_ANCHOR_TOPLEFT, source_type);
}
bool ToolbarActionView::CloseActiveMenuIfNeeded() {
« no previous file with comments | « chrome/browser/ui/views/toolbar/app_menu.cc ('k') | chrome/browser/ui/views/toolbar/toolbar_button.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698