chrome/browser/ui/views/toolbar/app_menu.h - Issue 2790773002: Cleanup MenuRunner API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/app_menu.h

Issue 2790773002: Cleanup MenuRunner API (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/app_menu.h

diff --git a/chrome/browser/ui/views/toolbar/app_menu.h b/chrome/browser/ui/views/toolbar/app_menu.h

index 10bb30356b36d547a6bda370fe2e6952873295fb..7e34995c9af804039a9743828ebe09590747732e 100644

--- a/chrome/browser/ui/views/toolbar/app_menu.h

+++ b/chrome/browser/ui/views/toolbar/app_menu.h

@@ -96,8 +96,7 @@ class AppMenu : public views::MenuDelegate,

void WillShowMenu(views::MenuItemView* menu) override;

void WillHideMenu(views::MenuItemView* menu) override;

bool ShouldCloseOnDragComplete() override;

- void OnMenuClosed(views::MenuItemView* menu,

- views::MenuRunner::RunResult result) override;

+ void OnMenuClosed(views::MenuItemView* menu) override;

bool ShouldExecuteCommandWithoutClosingMenu(int command_id,

const ui::Event& event) override;