chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc - Issue 2790773002: Cleanup MenuRunner API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

Issue 2790773002: Cleanup MenuRunner API (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/page_info/permission_selector_row.cc ('k') | chrome/browser/ui/views/status_icons/status_icon_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

diff --git a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

index 0933b3b687433b52594005478be3a3432f319c2f..9ca35cec672045c1f32f5abc801c3245d4121afa 100644

--- a/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

+++ b/chrome/browser/ui/views/permission_bubble/permission_prompt_impl.cc

@@ -117,9 +117,8 @@ void PermissionCombobox::GetAccessibleNodeData(ui::AXNodeData* node_data) {

void PermissionCombobox::OnMenuButtonClicked(views::MenuButton* source,

const gfx::Point& point,

const ui::Event* event) {

- menu_runner_.reset(new views::MenuRunner(

- model_.get(),

- views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::ASYNC));

+ menu_runner_.reset(

+ new views::MenuRunner(model_.get(), views::MenuRunner::HAS_MNEMONICS));

gfx::Point p(point);

p.Offset(-source->width(), 0);